Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lucide Icons & Minimize Property Menu #57

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Lucide Icons & Minimize Property Menu #57

merged 3 commits into from
Jan 19, 2024

Conversation

cpresler
Copy link
Contributor

@cpresler cpresler commented Jan 9, 2024

  • Minimize the width of the existing property menu to make space for future features
  • Swap out existing utility icons for Lucide versions
    • I left existing brand icons as they were because Lucide did not cover all of the existing brands, and it seemed better to keep them consistent
  • Update non-Lucide icons to accept a color property for use in the property menu, or other locations that require a non-black fill for the icon

@cpresler cpresler requested a review from ryansrofe January 9, 2024 15:07
@cpresler cpresler linked an issue Jan 9, 2024 that may be closed by this pull request
Settings: update to lucide icons for all property menu options instead of text and throughout the app #39
Closed
ryansrofe
ryansrofe approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@ryansrofe ryansrofe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's merge this.

I would still like to explore icons for all these in the future, specifically icons that have an on-state and an off-state. A good example is the open eye and closed eye.

@cpresler cpresler merged commit 6403ece into main Jan 19, 2024
1 check passed
@cpresler cpresler deleted the fl-39-icons branch January 19, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansrofe ryansrofe ryansrofe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings: update to lucide icons for all property menu options instead of text and throughout the app
2 participants
@cpresler @ryansrofe