Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Property Placement #80

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Version Property Placement #80

merged 2 commits into from
Apr 16, 2024

Conversation

ryansrofe
Copy link
Collaborator

Description

This PR moves the version option after the status option in the widget property menu. This groups the default options in terms of on and off. I also removed the single separator, it doesn't need to be there.

(the other formatting changes were automatically made)

How Has This Been Tested?

I tested the updates locally within Figma.

moves version option to be after status
also removes the separator, doesn't need to be there
(the other formatting changes were automatically made)
@ryansrofe ryansrofe added the refactor Improvements or changes to an existing feature label Apr 16, 2024
@ryansrofe ryansrofe added this to the Version 3 milestone Apr 16, 2024
@ryansrofe ryansrofe requested a review from cpresler April 16, 2024 13:08
Copy link
Contributor

@cpresler cpresler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

For a future PR, if you're using a linter to specify particular formatting, etc it would be good for project health to add that into the project so that it is consistent across everyone's local environments.

@ryansrofe
Copy link
Collaborator Author

Changes look good.

For a future PR, if you're using a linter to specify particular formatting, etc it would be good for project health to add that into the project so that it is consistent across everyone's local environments.

I think this is Prettier code formatting. There is a .prettierrc file in the repo that should enforce prettier formatting. If we need to add something else I can do that. I'm thinking maybe I have my prettier settings so that on save it formats. This might be something I should add to the README.

@ryansrofe ryansrofe merged commit 75e875d into main Apr 16, 2024
1 check passed
@ryansrofe ryansrofe deleted the property-menu-order branch April 16, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements or changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants