Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] BUG: hidden app roots #104

Closed
wants to merge 45 commits into from
Closed

[WIP] BUG: hidden app roots #104

wants to merge 45 commits into from

Conversation

ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented Feb 26, 2019

When an application root has no actual node_modules in it, the versions action inference fails to find the app root package.json file and misses traversing the versions dependencies. This has the buggy effects of:

  • Missing information in versions action for CLI
  • Missing information in DuplicatesPlugin.

Work

Example

The regression fixture displays similar bad output to the original bug #103 :

[Building fixture] ../../test/fixtures/hidden-app-roots/dist-production-4/bundle.js

Hash: ad1c54643fd96dfbb316
Version: webpack 4.6.0
Time: 169ms
Built at: 2019-02-26 11:16:37
     Asset       Size  Chunks             Chunk Names
 bundle.js  874 bytes       0  [emitted]  bundle
stats.json   8.38 KiB          [emitted]  
Entrypoint bundle = bundle.js
[4] ./packages/hidden-app/src/index.js 245 bytes {0} [built]
    + 4 hidden modules

WARNING in Duplicate Sources / Packages - Duplicates found! ⚠️

* Duplicates: Found 2 similar files across 2 code sources (both identical + similar)
  accounting for 118 bundled bytes.
* Packages: Found 0 packages with 0 resolved, 0 installed, and 0 depended versions.

* Understanding the report: Need help with the details? See:
  https://github.com/FormidableLabs/inspectpack/#diagnosing-duplicates
* Fixing bundle duplicates: An introductory guide:
  https://github.com/FormidableLabs/inspectpack/#fixing-bundle-duplicates

@ryan-roemer
Copy link
Member Author

Closing and re-opening to kick new Travis integration.

@ryan-roemer ryan-roemer reopened this Mar 19, 2019
@ryan-roemer
Copy link
Member Author

Closing and re-opening again to try again to kick Travis post-migration.

@ryan-roemer ryan-roemer reopened this Mar 20, 2019
@ryan-roemer ryan-roemer mentioned this pull request Mar 20, 2019
4 tasks
@ryan-roemer
Copy link
Member Author

Closing in favor of #107

@ryan-roemer ryan-roemer deleted the bug/hidden-app-roots branch March 26, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Application roots without node_modules on disk are missed for versions inference.
1 participant