Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Experimental Feature: Add versions plugin #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

step2yeung
Copy link

Opening this PR to generate discussion on this new plugin:

Problem: inspect versions of all the packages bundled in each asset. (#168)

Proposal: The version plugin reports the version information (without the summary) as the version action when duplicatesOnly=true. When duplicatesOnly=false, the plugin reports version information for each package found in each asset.

Sample output

        WARNING in Versions info - All Packages

        Single version packages
        ## `bundle.js`
        * bar
          * 3.4.0
            * Num deps: 1, files: 3
              * [email protected] -> bar@~3.4.0
        * baz
          * 1.2.0
            * Num deps: 1, files: 2
              * [email protected] -> baz@~1.2.0
        
        Duplicate version packages
        ## `bundle.js`
        * @scope/foo
          * 1.1.1
            * ~/@scope/foo
              * Num deps: 2, files: 2
              * [email protected] -> @scope/foo@^1.0.9
              * [email protected] -> flattened-foo@^1.1.0 -> @scope/foo@^1.1.1
          * 2.2.2
            * ~/uses-foo/~/@scope/foo
              * Num deps: 1, files: 1
              * [email protected] -> uses-foo@^1.0.9 -> @scope/foo@^2.2.0
        * foo
          * 3.3.3
            * ~/unscoped-foo/~/foo
              * Num deps: 1, files: 2
              * [email protected] -> unscoped-foo@^1.0.9 -> foo@^3.3.0
          * 4.3.3
            * ~/unscoped-foo/~/deeper-unscoped/~/foo
              * Num deps: 1, files: 2
              * [email protected] -> unscoped-foo@^1.0.9 -> deeper-unscoped@^1.0.0 -> foo@^4.0.0

TODOs

  • Add the summary back and figure out what to report when duplicatesOnly=false
  • Share reporting logic between the plugin & action
  • Update README
  • Tests

@step2yeung step2yeung changed the title Add versions plugin [WIP] Experimental Feature: Add versions plugin Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant