-
Notifications
You must be signed in to change notification settings - Fork 18
[WIP] Native checks #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ceceppa
wants to merge
13
commits into
main
Choose a base branch
from
native-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Native checks #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* expo module * expo module * Initial iOS & Android error check implementation * Prettier fix * move example to playground * make clear error * improve playground app
* fixes to get AMA playground running. still WIP * fix build
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accessibility checks are now primarily performed on the native side, allowing users to rely directly on our custom components (such as Pressable, Text, etc.) for immediate feedback about common accessibility issues. Additionally, this change ensures broader compatibility, allowing the library to integrate seamlessly with any other React Native UI library.
A new Playground app has also been added, providing users a hands-on environment to explore the library’s capabilities, better understand accessibility issues identified by AMA, and practice fixing them interactively.
Extras
Feedback View
TODO
Checks
Pressable
Text
Headers
UI Interaction
Check if is possible to hijack pressable events to see if its triggering did cause some UI change. For example some new element appeared or changed...
This could allow AMA to possible detect:
Forms
Close #324
Type of Change
How Has This Been Tested?
Using the built-in
playground
appChecklist: (Feel free to delete this section upon completion)