Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engines node version #360

Merged
merged 1 commit into from
Dec 23, 2024
Merged

engines node version #360

merged 1 commit into from
Dec 23, 2024

Conversation

nlkluth
Copy link
Member

@nlkluth nlkluth commented Dec 19, 2024

Add engines field in package.json so vercel can use supported node versions

at the time of this PR >= 18.0.0 will use v22

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 11fb6fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-swipeable ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:25pm

Copy link
Contributor

size-limit report 📦

Path Size
lib/index.js 1.63 KB (0%)
dist/react-swipeable.js 1.72 KB (0%)
es/index.js 1.72 KB (0%)

Copy link
Collaborator

@hartzis hartzis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's up @nlkluth cool to see you virtually 👋

💭 this shouldn't effect any build tools like vite or webpack should it?

@nlkluth
Copy link
Member Author

nlkluth commented Dec 20, 2024

@hartzis ! Waddup!? 🎸

I ran a few of the commands locally with v20, and the build passes on vercel with v22. So it seems to be OK. Happy to run other tests if you'd like or if you would prefer I can use a more precise version. The hope with >= 18.0.0 was to not interrupt too much local development, while getting vercel to a happy point

@hartzis
Copy link
Collaborator

hartzis commented Dec 20, 2024

that's awesome 🚢 it 😃

@nlkluth nlkluth merged commit d124910 into main Dec 23, 2024
6 checks passed
@nlkluth nlkluth deleted the engines-node-version branch December 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants