-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/spectacle mdx loader addition #1228
Conversation
@paulmarsicloud I've finished my cleanup of examples configs and dependencies. Mind double checking my commits? @carlos-kelly @gksander @fritz-c I've noticed a discrepancy in code blocks in MD vs. MDX. For our MD example with For our MDX example with Any ideas here? Thanks! |
Offhand, now that I'm looking at things looks like our |
Per slack discussion, we're not blocking on this and I've filed #1232 to capture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Paul! 🎉
Commits look good and works proper on my end! |
@paulmarsicloud We're missing a |
Ryan is more on top of the PR at this point
I've added the |
…idableLabs/spectacle into chore/spectacle-mdx-loader-addition
Description
First pass and attempt at bringing in
spectacle-mdx-loader
into the monorepo. Took onboard @ryan-roemer's advice to remove all devDeps and scripts and focus on gettinglint
andprettier
working as a start. Movedprop-types
andspectacle-mdx-loader
into top-levelpackage.json
so thatspectacle-mdx-loader
could be called directly fromexamples/mdx/webpack.config.js
.In a good spot now for a second pair of eyes to take a look through 👍
Fixes #1164
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
pnpm run check:ci
and all checks pass