Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add its-fine for polar charts #440

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Add its-fine for polar charts #440

merged 3 commits into from
Dec 9, 2024

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Dec 5, 2024

Description

Adds its-fine for polar charts since the current implementation of sharing contexts between renderers no longer seems like it's working.

This isn't the most ideal solution, but it will at least fix the errors that are thrown/logged currently for existing users. See #433 for more details

Fixes #433

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@zibs zibs requested a review from keithluchtel December 5, 2024 19:55
Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: f7f5c22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 4:41pm

@alex-oiqia
Copy link

HI, We are waiting the merge, please review it !!

@zibs zibs merged commit d34b96b into main Dec 9, 2024
3 checks passed
@zibs zibs deleted the task/its-fine branch December 9, 2024 17:17
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Detected multiple renderers concurrently rendering the same context provider in PolarChart
4 participants