Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix table structure follow specification (refs SFKUI-6500) #123

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

NicklasWei
Copy link
Contributor

Störde mig på varningarna i jest testet för FCrudDataset:
[Vue warn]: <tr> cannot be child of <table>, according to HTML specifications. This can cause hydration errors or potentially disrupt future functionality.

Åtgärdade varningen och körde prettier på html-blocket.

Copy link

github-actions bot commented Nov 22, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-28 09:19 UTC

@ext
Copy link
Contributor

ext commented Nov 24, 2024

[Vue warn]: <tr> cannot be child of <table>, according to HTML specifications.

Mja, det är ju inte riktigt sant, låt mig citera vad standarden säger (emphasis mine):

Contexts in which this element can be used:

[...]
As a child of a table element, after any caption, colgroup, and thead elements, but only if there are no tbody elements that are children of the table element.

Sen är det ju bättre att köra med <thead> och <tbody> såklart så ändå en rimlig PR vill bara rent pedantiskt få ur mig att varningen är felaktig.

@ext
Copy link
Contributor

ext commented Nov 24, 2024

Ser att det finns en bug mot Vue också: vuejs/core#12088

@ext ext merged commit 75a3fd2 into main Nov 28, 2024
13 checks passed
@ext ext deleted the crud-table-correction branch December 6, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants