Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We build for china #490

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

cornercube
Copy link
Contributor

@cornercube cornercube commented Mar 31, 2024

About The Pull Request

makes chairmain cheng proud of us

makes the type-17 chinese pistol load from stripper clips into an internal magazine as per the game/real life
a debuff since you cant load extended mags into it, though it has a very niche upside of being able to load free bullets into it by hand without the need for magazines
also adds 10-rnd stripper clips for use in the type-17 (zip gun clip as a placeholder, until someome makes a nice looking one)

not china related, but stats for a laser carbine were also added

adds the chinese militant outfit, for more chinese swag
image
sprite courtesy of infrared baron

Why It's Good For The Game

-chinese pistol is no longer a 10mm pistol clone, more of a semi-clone now
allows you to say you are loading a clip without being wrong
lore compliant
-new outfit to wear if you like being chinese, inspired by an F76 outfit
-minor bugfixes, while we are at it

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: 10-round, 10mm ammo clip
add: chinese militant suit and cap
add: FO4 laser gun (laser carbine) added for testing
change: chinese pistol now accepts stripper clips
del: some unnecessary lines from the chinese officer hat and uniform
fix: chinese officer sword inhand shows up now
/:cl:

@cornercube cornercube marked this pull request as ready for review April 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants