Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new mech guns, two new cars (unobtainable), and tidies the mech directory, armor stacks now and uses more gazz, gives hydraulic clams to pickutrucks, adds trunks and seats to crafting menu #222

Open
wants to merge 73 commits into
base: master
Choose a base branch
from

Conversation

githubuser4141
Copy link
Contributor

@githubuser4141 githubuser4141 commented Sep 25, 2024

About The Pull Request

Adds a new mech gun (minigun) to the game, tidies the mech "phazon" directory.
Mechs now use a equipment system ported from Polaris, equipment is divided into 3 groups "weapons, utility and misc".
Also corrects some weird pixel x/y values to make certain mechs look better going through doorways/more centered.
Adds vision modules, things that occupy a misc slot on vehicles (same as armor and repair droids) and grant NVGs + mesons or thermals. Adds two new, highly expensive, armored fighting vehicles to the crafting menu, temporary for now and
eventually they should be craftabble using proper car crafting techniques.

Also makes armor stack, armor uses the UTILITY slot now, armor also increases gazz consumption, adds vehicle armor defines that don't use line armor, gives hydraulic clamps and storage to pickuptrucks and jeeps, and makes trunks and chairs craftable

Might contain WIP stuff, all code is definitely ported from elsewhere

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
tweak: Tidies the phazon directory into separate files for better organization. Slight change to mech gear slots. Adjusts pixel x/y values to make mechs look better/more centered in doorways. Adds 2 AFVs to craft in the crafting menu, eventually they should be craftable using car crafting (not yet added).
balance: Mech shotguns and mech LMGs use existing projectiles now (9mm and buck/trainshot), adds a minigun. Adds a new car that's currently not implemented. Mech guns are adjusted slightly. Adds mech vision modules. Adds chair and trunk crafting. Mech armor stacks now and uses more gazzolene. Adds hydraulic clams to pickuptrucks.
/:cl:

@githubuser4141 githubuser4141 mentioned this pull request Sep 25, 2024
3 tasks
@xTrainx
Copy link
Contributor

xTrainx commented Sep 25, 2024

What's wrong with my mini gun?

@githubuser4141
Copy link
Contributor Author

What's wrong with my mini gun?

I'm not sure, is there something wrong with it? I uncommented it and put it in the crafting menu, tested and it seemed to work (fires in full auto, overheats), but I'm not a coder, the code here is ported from elsewhere

@Aurrain Aurrain added feature addition Adds something new to the game work-in-progress This PR is not yet finished needs work Something isn't right with this PR labels Sep 26, 2024
@Aurrain
Copy link
Contributor

Aurrain commented Sep 26, 2024

Looks like some checks failed, I noticed a warning of "Check warning on line 138 in code/datums/components/crafting/recipes/vehicle_parts.dm" most notably.

@githubuser4141
Copy link
Contributor Author

Looks like some checks failed, I noticed a warning of "Check warning on line 138 in code/datums/components/crafting/recipes/vehicle_parts.dm" most notably.

Should be fixed now

@githubuser4141 githubuser4141 changed the title Adds new mech guns, two new cars, and tidies the mech directory, armor stacks now and uses more gazz, gives hydraulic clams to pickutrucks, adds trunks and seats to crafting menu Adds new mech guns, two new cars (unobtainable), and tidies the mech directory, armor stacks now and uses more gazz, gives hydraulic clams to pickutrucks, adds trunks and seats to crafting menu Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature addition Adds something new to the game Merge Conflict needs work Something isn't right with this PR work-in-progress This PR is not yet finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants