Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply Vendors for NCR and Legion and EXPORT vendor in the town shop #252

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Loldaddy5676
Copy link

@Loldaddy5676 Loldaddy5676 commented Oct 24, 2024

About The Pull Request

Ncr and Legion now have supply vendors with basic to mid-tier equipment to give their troops upgrades. gives reason for both factions to actually collect caps. Export vendor added to town with certain items to sell to ???. more items to be added to this pool in the future. also makes the medical vendor of healing items cheaper so people can fucking buy meds.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: Added Supply vendors to the NCR and Legion base
add: Added Export vendor to the town shop for people to sell stuff.
Tweaked: Prices of healing items in medical vendor
add: Added secret to map somewhere........ shhh

Ncr and Legion now have supply vendors with basic to mid-tier equipment to give their troops upgrades. gives reason for both factions to actually collect caps.
@Aurrain Aurrain added feature addition Adds something new to the game balance This PR messes with the general balance of the game labels Oct 28, 2024
@Loldaddy5676 Loldaddy5676 changed the title Supply Vendors for NCR and Legion Supply Vendors for NCR and Legion and EXPORT vendor in the town shop Nov 5, 2024
@BoltedAirlock
Copy link

why on earth does this PR remove the gun repository on pahrump and not mention it anywhere in the changes?

@Loldaddy5676
Copy link
Author

why on earth does this PR remove the gun repository on pahrump and not mention it anywhere in the changes?

Forgot to add it into CL. Will do that when I make a few more changes to these vendors.

@Loldaddy5676
Copy link
Author

last few changes I have for this pr before its ready to be fully merged

  1. brotherhood vendor
  2. Enclave vendor
  3. Vehicle equipment and ammo vendor
  4. even more shit into export vendor

@SirSwagmeyer
Copy link
Contributor

I'm just here to say that after the testmerge, the GnB price gouging has completely gutted most players from even attempting to craft weapons. It shouldn't cost an upwards of half a grand of caps just to buy some books.

@SirSwagmeyer
Copy link
Contributor

Just to add to what I said earlier, you're creating scarcity for the sake of scarcity, which makes zero sense considering the absolute shambles the caps economy is right now - the main method of collecting caps is farming ghouls from the infinite dungeon spawners for caps. You shouldn't be forcing scarcity when caps are already an extremely rare resource.

@Loldaddy5676
Copy link
Author

Just to add to what I said earlier, you're creating scarcity for the sake of scarcity, which makes zero sense considering the absolute shambles the caps economy is right now - the main method of collecting caps is farming ghouls from the infinite dungeon spawners for caps. You shouldn't be forcing scarcity when caps are already an extremely rare resource.

Seeing how you can easily get caps with the export vendor where I plan to merge the gun repository into it and add even more stuff to sell off. Caps will slowly be more avaible.

I increased the GnB prices since it became too easy to get all the GnB books quickly, if it's too expensive, I can knock the prices by a little bit.

@Defaulterrama
Copy link

Letting us sell combat armor, research documents, and meds (at 1/4 of their actual value if not less) isn't worth this much of a price-change. Like the export vendor in it's current state isn't even a big economical change. Although I will say it's also crazy to think that everyone is going to have access to this vendor reliably within the Town and make changes to the whole map's economy as a result of it's existence. (nerf GnB prices into the ground, faction members don't BUY them they get them off dungeon delving and this change is dumb and ur just fucking up the already terrible wastelander basemaker experience.)

@Loldaddy5676
Copy link
Author

prices for GnB books reduced back to their orignal prices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
balance This PR messes with the general balance of the game feature addition Adds something new to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants