Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import vendors for ncr/legion/Shopkeep. Export vendor in town shop. Replaces unused basement of bar into a Town safe house. #252

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

Loldaddy5676
Copy link

@Loldaddy5676 Loldaddy5676 commented Oct 24, 2024

About The Pull Request

NCR and legion has new import vendors to spend their hard earned caps. Town has a export vendor to revitalize the economy. due to the amount of times the town has been raided, the town has refitted the old basement of the bar into a safe house, to keep their citizens away from harm.

UPDATE:
Shopkeep now has a vendor to purchase tiers 2 and 3 armor at SLIGHTLY below market value. gacha system
Export vendor now has more shit to purchase from the player, tiers 1-4 plus raider armor added into it, Oats, wheat, and the other forgettable crop added into it, ALL the meats are added into it.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: Added Supply vendors to the NCR and Legion base and Shopkeep basement
add: Added Export vendor to the town shop for people to sell stuff.
Tweaked: Prices of healing items in medical vendor
add: Added secret to map somewhere........ shhh
add: New Town Panic Room.

Ncr and Legion now have supply vendors with basic to mid-tier equipment to give their troops upgrades. gives reason for both factions to actually collect caps.
@Aurrain Aurrain added feature addition Adds something new to the game balance This PR messes with the general balance of the game labels Oct 28, 2024
@Loldaddy5676 Loldaddy5676 changed the title Supply Vendors for NCR and Legion Supply Vendors for NCR and Legion and EXPORT vendor in the town shop Nov 5, 2024
@BoltedAirlock
Copy link
Contributor

why on earth does this PR remove the gun repository on pahrump and not mention it anywhere in the changes?

@Loldaddy5676
Copy link
Author

why on earth does this PR remove the gun repository on pahrump and not mention it anywhere in the changes?

Forgot to add it into CL. Will do that when I make a few more changes to these vendors.

@Loldaddy5676
Copy link
Author

last few changes I have for this pr before its ready to be fully merged

  1. brotherhood vendor
  2. Enclave vendor
  3. Vehicle equipment and ammo vendor
  4. even more shit into export vendor

@SirSwagmeyer
Copy link
Contributor

I'm just here to say that after the testmerge, the GnB price gouging has completely gutted most players from even attempting to craft weapons. It shouldn't cost an upwards of half a grand of caps just to buy some books.

@SirSwagmeyer
Copy link
Contributor

Just to add to what I said earlier, you're creating scarcity for the sake of scarcity, which makes zero sense considering the absolute shambles the caps economy is right now - the main method of collecting caps is farming ghouls from the infinite dungeon spawners for caps. You shouldn't be forcing scarcity when caps are already an extremely rare resource.

@Loldaddy5676
Copy link
Author

Just to add to what I said earlier, you're creating scarcity for the sake of scarcity, which makes zero sense considering the absolute shambles the caps economy is right now - the main method of collecting caps is farming ghouls from the infinite dungeon spawners for caps. You shouldn't be forcing scarcity when caps are already an extremely rare resource.

Seeing how you can easily get caps with the export vendor where I plan to merge the gun repository into it and add even more stuff to sell off. Caps will slowly be more avaible.

I increased the GnB prices since it became too easy to get all the GnB books quickly, if it's too expensive, I can knock the prices by a little bit.

@Defaulterrama
Copy link

Letting us sell combat armor, research documents, and meds (at 1/4 of their actual value if not less) isn't worth this much of a price-change. Like the export vendor in it's current state isn't even a big economical change. Although I will say it's also crazy to think that everyone is going to have access to this vendor reliably within the Town and make changes to the whole map's economy as a result of it's existence. (nerf GnB prices into the ground, faction members don't BUY them they get them off dungeon delving and this change is dumb and ur just fucking up the already terrible wastelander basemaker experience.)

@Loldaddy5676
Copy link
Author

prices for GnB books reduced back to their orignal prices.

@Loldaddy5676
Copy link
Author

Loldaddy5676 commented Nov 17, 2024

Silver, gold, and diamonds, wheat, rice, oats, ncr salvaged power armor, proper brotherhood combat armor have been added to the export vendor

Enclave vendor and brotherhood vendor will be added in a later pr.

Soon to be added to export vendor:

  1. more crops
  2. Weapons
  3. perhaps a shop import vendor as a heavily nerfed cargo system.

@Loldaddy5676 Loldaddy5676 changed the title Supply Vendors for NCR and Legion and EXPORT vendor in the town shop Import vendors for ncr/legion. Export vendor in town shop. New enclave hobo encampment because I don't know how to open a second pr god help me. Nov 17, 2024
@Loldaddy5676 Loldaddy5676 changed the title Import vendors for ncr/legion. Export vendor in town shop. New enclave hobo encampment because I don't know how to open a second pr god help me. Import vendors for ncr/legion. Export vendor in town shop. Replaces unused basement of bar into a Town safe house. Nov 18, 2024
@Loldaddy5676
Copy link
Author

FARMERS AND HUNTERS REJOICE, MEATS NOW IN EXPORT VENDOR

Tiers 1 to 5 loot pool has been added to export vendor, Shopkeep now has a vendor to get supplies slightly below market value.
@Loldaddy5676 Loldaddy5676 changed the title Import vendors for ncr/legion. Export vendor in town shop. Replaces unused basement of bar into a Town safe house. Import vendors for ncr/legion/Shopkeep. Export vendor in town shop. Replaces unused basement of bar into a Town safe house. Nov 24, 2024
@Aurrain
Copy link
Contributor

Aurrain commented Nov 29, 2024

Will need an update to reflect recent map changes, conflict is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
balance This PR messes with the general balance of the game feature addition Adds something new to the game Merge Conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants