Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIN-270: Stratum v1 Rust no_std no_alloc Client #42

Merged
merged 1 commit into from
Sep 16, 2024
Merged

MIN-270: Stratum v1 Rust no_std no_alloc Client #42

merged 1 commit into from
Sep 16, 2024

Conversation

georgesFoundation
Copy link
Collaborator

Add a no_std no_alloc Stratum v1 client crate

@georgesFoundation
Copy link
Collaborator Author

A real-life usage implementation is available at : https://github.com/bitaxeorg/esp-miner-rs

@georgesFoundation
Copy link
Collaborator Author

georgesFoundation commented Aug 28, 2024 •
edited
Loading

Note, I still can't cargo package it until faster-hex merge and publish nervosnetwork/faster-hex/pull/48 and nervosnetwork/faster-hex/pull/49

@georgesFoundation georgesFoundation changed the title Stratum v1 MIN-270: Stratum v1 Rust no_std no_alloc Client Aug 28, 2024
jeandudey
jeandudey requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@jeandudey jeandudey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM, just some nit picks

Cargo.toml Outdated Show resolved Hide resolved
stratum-v1/src/client/request.rs Outdated Show resolved Hide resolved
jeandudey
jeandudey approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@jeandudey jeandudey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgesFoundation georgesFoundation force-pushed the stratum-v1 branch 4 times, most recently from 1b02779 to fe1b48b Compare September 16, 2024 14:03
@georgesFoundation georgesFoundation merged commit d755a24 into main Sep 16, 2024
11 checks passed
@georgesFoundation georgesFoundation deleted the stratum-v1 branch September 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeandudey jeandudey jeandudey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgesFoundation @jeandudey