SFT-3480: Add firmware image signature verification #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandudey
force-pushed
the
jeandudey/sft-3480-replicate-checks-from-bootloader-when-upgrading
branch
3 times, most recently
from
4f79c5d to
3859b88
Compare
mjg-foundation
force-pushed
the
dev-v2.4.0
branch
from
c166616 to
f11cacb
Compare
jeandudey
force-pushed
the
jeandudey/sft-3480-replicate-checks-from-bootloader-when-upgrading
branch
2 times, most recently
from
a825548 to
13ba9e9
Compare
jeandudey
force-pushed
the
jeandudey/sft-3480-replicate-checks-from-bootloader-when-upgrading
branch
from
13ba9e9 to
0a630b6
Compare
FoundationKen
previously approved these changes
Jul 15, 2024
* Cargo.lock: Update lockfile. * Cargo.toml (dependencies) <foundation-firmware>: New dependency.
* extmod/foundation-rust/include/foundation.h: Update bindings. * extmod/foundation-rust/src/firmware.rs: New module. * extmod/foundation-rust/src/lib.rs (firmware): Register module. * ports/stm32/boards/Passport/modpassport-system.h (mod_passport_System_validate_firmware_header): Remove procedure. (mod_passport_System_validate_firmware_header_obj): Remove variable. (mod_passport_System_locals_dict_table): Remove validate_firmware_header. * ports/stm32/boards/Passport/modpassport.c (mod_passport_verify_update_header): New procedure. (mod_passport_verify_update_header_obj): New variable. (passport_module_globals_table): Add verify_update_header. * ports/stm32/boards/Passport/modules/flows/update_firmware_flow.py (UpdateFirmwareFlow) <show_firmware_details>: Use verify_update_header instead of validate_firmware_header. * ports/stm32/boards/Passport/modules/tasks/verify_firmware_signature_task.py: Add new task.
jeandudey
force-pushed
the
jeandudey/sft-3480-replicate-checks-from-bootloader-when-upgrading
branch
from
0a630b6 to
7003eaa
Compare
FoundationKen
approved these changes
Jul 16, 2024
jeandudey
deleted the
jeandudey/sft-3480-replicate-checks-from-bootloader-when-upgrading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same as the bootloader but verifies the image before copying it to check if the user has a corrupt firmware image. The bootloader checked this anyway so this is an extra layer of measure.