Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not compile nofile_limit util functions on Windows #30

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

icota
Copy link
Collaborator

@icota icota commented Jan 22, 2024

Should fix #29

@icota icota mentioned this pull request Jan 22, 2024
@H3mnz
Copy link

H3mnz commented Jan 22, 2024

With comment this lines in rust/src/lib.rs

pub use crate::util::tor_get_nofile_limit;
pub use crate::util::tor_set_nofile_limit;

it works on the windows

@icota
Copy link
Collaborator Author

icota commented Jan 22, 2024

Thank you for testing @H3mnz. Does it now work without you making any changes in b8dcfef?

@H3mnz
Copy link

H3mnz commented Jan 22, 2024

Yes, it works in b8dcfef

@icota icota merged commit b31e4db into main Jan 22, 2024
1 check passed
sneurlax pushed a commit to cypherstack/tor that referenced this pull request Jun 13, 2024
7a5bba8 fix: setup flutter environment for Xcode iOS builds (Foundation-Devices#30)
7467b9a fix: build_pod.sh should setup flutter environment (Foundation-Devices#29)
0f0359e fix: install targets for correct toolchain (#26)

git-subtree-dir: cargokit
git-subtree-split: 7a5bba8eefbfe7e567f754477fd172e7a06b153f
sneurlax pushed a commit to cypherstack/tor that referenced this pull request Jun 22, 2024
7a5bba8 fix: setup flutter environment for Xcode iOS builds (Foundation-Devices#30)

git-subtree-dir: cargokit
git-subtree-split: 7a5bba8eefbfe7e567f754477fd172e7a06b153f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed on the windows
2 participants