Three data hall fault domain storage check bug fix

[simenl]

Description

The operator should be allowed to remove processes when a cluster running with three_data_hall redundancy is healthy and have minimum three replicas of storage data (not four).
Fixes #1861

Type of change

Please select one of the options below.

• Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

• Unit tests which checks if removals happen based on MinReplicasRemaining in the team tracker status.
• Manually verified removal of processes in a running three_data_hall cluster.

Documentation

Follow-up

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: a3d8ad5
• Duration 2:51:34
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

The changes look fine, could you please fix the issues with the code by running make fmt lint test? There are some compiler issues.

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 04265f4
• Duration 2:47:23
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

LGTM 👍