Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the three_data_hall docs for the three data hall with unified image #2188

Merged

Conversation

johscheuer
Copy link
Member

Description

Updating the docs for three data hall with the unified image and add a new e2e test case as the setup is simpler than with the split image.

Type of change

  • Other

Discussion

Are there any design details that you would like to discuss further?

Testing

Ran manually:

[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.001 seconds]
------------------------------

Ran 3 of 3 Specs in 791.948 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestOperator (791.95s)
PASS
ok      github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_three_data_hall       792.588s

Documentation

Updated. I have to go over the documentation in another PR to make sure we update all places where we mention three data hall.

Follow-up

See above :)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 720ba22
  • Duration 2:50:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer
Copy link
Member Author

johscheuer commented Dec 19, 2024

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 720ba22
  • Duration 2:50:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Seems like our logic that checks for failures makes a mistake here:

[Container] 2024/12/18 21:02:22.897240 Running command for f in $(grep -L -- "SUCCESS\! --" ${CODEBUILD_SRC_DIR}/logs/*.log); do if ! grep -q -- "--- FAIL:" $f; then echo "This test has timed out or had a panic: $f"; export fail_test=true; fi ;  done
This test has timed out or had a panic: /codebuild/output/src1586222057/src/github.com/FoundationDB/fdb-kubernetes-operator/logs/test_operator_three_data_hall.log
=== RUN   TestOperator
  "level"=0 "msg"="waiting for" "2m27s"="before executing test suite"
Running Suite: Operator three data hall test suite - /codebuild/output/src1586222057/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_three_data_hall
==========================================================================================================================================================================
Random Seed: 1734546062

Will run 3 of 3 specs
------------------------------
[BeforeSuite] 
/codebuild/output/src1586222057/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_three_data_hall/operator_three_data_hall_test.go:51
  2024/12/18 18:23:30 using seed: 1734546210 for factory
  [SKIPPED] in [BeforeSuite] - /codebuild/output/src1586222057/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_three_data_hall/operator_three_data_hall_test.go:54 @ 12/18/24 18:23:30.593
S [SKIPPED] [0.609 seconds]
[BeforeSuite] 
/codebuild/output/src1586222057/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_three_data_hall/operator_three_data_hall_test.go:51

  [SKIPPED] three data hall tests are only supported with the unified image
  In [BeforeSuite] at: /codebuild/output/src1586222057/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_three_data_hall/operator_three_data_hall_test.go:54 @ 12/18/24 18:23:30.593
------------------------------
SSS
------------------------------
[AfterSuite] 
/codebuild/output/src1586222057/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_three_data_hall/operator_three_data_hall_test.go:83
  2024/12/18 18:23:45 Calling 0 invariantShutdownHooks
  2024/12/18 18:23:45 Calling 0 shutdownHooks
  2024/12/18 18:23:45 Shutdown is done
[AfterSuite] PASSED [15.014 seconds]
------------------------------
[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.001 seconds]
------------------------------

Ran 0 of 3 Specs in 15.624 seconds
SUCCESS! - Suite skipped in BeforeSuite -- 0 Passed | 0 Failed | 0 Pending | 3 Skipped
--- PASS: TestOperator (162.63s)
PASS
ok  	github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_three_data_hall	162.687s

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a66a4a5
  • Duration 2:53:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@brownleej brownleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johscheuer johscheuer merged commit ff924de into FoundationDB:main Jan 9, 2025
8 checks passed
@johscheuer johscheuer deleted the update-three-data-hall-docs branch January 9, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants