Add validation to Insert statement parsing to match the column names with supplied values #3070
+224
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-record-layer-pr on Linux CentOS 7
|
arnaud-lacurie
requested changes
Jan 30, 2025
...java/com/apple/foundationdb/relational/recordlayer/ddl/DdlRecordLayerSchemaTemplateTest.java
Outdated
Show resolved
Hide resolved
...al-core/src/test/java/com/apple/foundationdb/relational/recordlayer/RelationalArrayTest.java
Outdated
Show resolved
Hide resolved
| // This phenomenon is also true with basic types, i.e., non-nullability is not enforced and is tracked by | ||
| // TODO (Add support + tests for column nullable/not null) | ||
| insertQuery("INSERT INTO T (pk) VALUES (4)"); | ||
| Assert.assertThrows(SQLException.class, () -> insertQuery("INSERT INTO T (pk) VALUES (4)")); |
There was a problem hiding this comment.
Can you use RelationalAssertions.assertThrowsSqlException that allows you to check for the error message and SQLState?
There was a problem hiding this comment.
Can you check the SQLState as well?
RelationalAssertions.assertThrowsSqlException has a method withErrorCode or something like this that you can use.
...al-core/src/test/java/com/apple/foundationdb/relational/recordlayer/RelationalArrayTest.java
Outdated
Show resolved
Hide resolved
...al-core/src/test/java/com/apple/foundationdb/relational/recordlayer/RelationalArrayTest.java
Outdated
Show resolved
Hide resolved
...al-core/src/test/java/com/apple/foundationdb/relational/recordlayer/RelationalArrayTest.java
Outdated
Show resolved
Hide resolved
...al-core/src/test/java/com/apple/foundationdb/relational/recordlayer/RelationalArrayTest.java
Outdated
Show resolved
Hide resolved
...al-core/src/test/java/com/apple/foundationdb/relational/recordlayer/RelationalArrayTest.java
Outdated
Show resolved
Hide resolved
g31pranjal
changed the title
Result of fdb-record-layer-pr on Linux CentOS 7
|
g31pranjal
force-pushed
the
insert_bug_fix
branch
from
cddee53 to
e5cd8c2
Compare
Result of fdb-record-layer-pr on Linux CentOS 7
|
arnaud-lacurie
requested changes
Feb 7, 2025
| - | ||
| # Case when the number of values is more than the number of columns specified. | ||
| - query: insert into A(A1, A2, A3) values (5, 6, 7, 8, 9); | ||
| - supported_version: !current_version | ||
| - error: "42601" | ||
| - | ||
| # Case when a nullable column's value is not provided |
There was a problem hiding this comment.
Just to cover that, could you add a test where the not provided column is the first one and another case where it's the last one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3069. This PR also provide a short-term solution to #3068
In essence, it does the following things:
INSERTstatement but its value is not provided.INSERTstatement is not equal to the number of values provided for a rowINSERTstatement or its value is not providedARRAY) asNOT NULLin the DDL since this feature is not fully supported throughout.DEFAULT}