Add GUI - for setting RGB LEDs on Framework Desktop #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rename Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
|
I can build and run it just fine on Windows, not sure why github actions fails. |
JohnAZoidberg
commented
Jul 24, 2025
Comment on lines
+11
to
+37
| // If the user double-clicks (opens from explorer/desktop), | ||
| // then we want to have the default behavior of showing a report of | ||
| // all firmware versions. | ||
| #[cfg(windows)] | ||
| let (args, double_clicked) = { | ||
| let double_clicked = unsafe { | ||
| // See https://devblogs.microsoft.com/oldnewthing/20160125-00/?p=92922 | ||
| let mut plist: winapi::shared::minwindef::DWORD = 0; | ||
| let processes = winapi::um::wincon::GetConsoleProcessList(&mut plist, 1); | ||
|
|
||
| // If we're the only process that means we're in a fresh terminal | ||
| // without CMD or powershell. This happens in some cases, for example | ||
| // if the user double-clicks the app from Explorer. | ||
| processes == 1 | ||
| }; | ||
| // But it also happens if launched from the commandline and a UAC prompt is necessary, | ||
| // for example with sudo set to open "In a new windows", therefore we also have to | ||
| // check that no commandline arguments were provided. | ||
| if double_clicked && args.len() == 1 { | ||
| ( | ||
| vec![args[0].clone(), "--versions".to_string()], | ||
| double_clicked, | ||
| ) | ||
| } else { | ||
| (args, double_clicked) | ||
| } | ||
| }; |
There was a problem hiding this comment.
Don't need all of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
The colors stay on, until the system resets.