Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lotus.lowpower #25

Closed
wants to merge 2 commits into from
Closed

Lotus.lowpower #25

wants to merge 2 commits into from

Conversation

kiram9
Copy link

@kiram9 kiram9 commented May 26, 2023

Reduce power consumption based on sleep# control. However power consumption is still not great.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@kiram9
add wfi to idle thread
316902e 
WIth this change power is reduced by 3mA

Signed-off-by: Kieran Levin <[email protected]>
@kiram9
implement backlight and lower power matrix scanning
5c4941e 
With this change the 3.3V rail gets down to 22mA
The backlight and power led will auto turn off when the keyboard
SLEEP# goes low, and will resume when the sleep pin goes high.

For some reason WFI does not sleep as long as I would expect.
Something is triggering interrupts constantly
that we need to figure out to save power.

Signed-off-by: Kieran Levin <[email protected]>
@KarlK90
Copy link
Contributor

KarlK90 commented Jun 5, 2023 •
edited
Loading

The only periodic irq's that come to mind in this rather barebones QMK configuration are the SOF USB interrupts which are enabled by default (and needed). Is the USB bus suspended in sleep mode?

@kiram9 kiram9 requested a review from JohnAZoidberg June 5, 2023 23:10
@KarlK90
Copy link
Contributor

KarlK90 commented Aug 6, 2023

@kiram9 you might want to try out this PR qmk/qmk_firmware#21656 which gets rid of the SOF interrupts that I suspect to wake the keyboard more often than necessary. There have also been multiple PRs to the RP2040 USB driver in ChibiOS-Contrib which should be picked up.

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale label Sep 21, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiram9 @KarlK90