Skip to content

Commit

Permalink
Merge pull request #1551 from Karry/drop-iconv2
Browse files Browse the repository at this point in the history
remvoe iconv from CMake and Github actions
  • Loading branch information
Framstag authored Jan 1, 2024
2 parents bfc6e05 + 83ee88b commit ec3471a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_and test_on_msys.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
uses: msys2/setup-msys2@v2
with:
update: true
install: "mingw-w64-x86_64-toolchain mingw-w64-x86_64-libtool mingw-w64-x86_64-libiconv
install: "mingw-w64-x86_64-toolchain mingw-w64-x86_64-libtool
mingw-w64-x86_64-cmake mingw-w64-x86_64-extra-cmake-modules mingw-w64-x86_64-ninja
mingw-w64-x86_64-protobuf
mingw-w64-x86_64-libxml2
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
uses: msys2/setup-msys2@v2
with:
update: true
install: "mingw-w64-x86_64-toolchain mingw-w64-x86_64-libtool mingw-w64-x86_64-libiconv
install: "mingw-w64-x86_64-toolchain mingw-w64-x86_64-libtool
mingw-w64-x86_64-meson mingw-w64-x86_64-ninja
mingw-w64-x86_64-protobuf
mingw-w64-x86_64-libxml2
Expand Down
5 changes: 0 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -562,11 +562,6 @@ if (TARGET harfbuzz::harfbuzz)
else ()
message(STATUS "- harfbuzz: FALSE")
endif ()
if (TARGET Iconv::Iconv)
message(STATUS "- Iconv: TRUE")
else ()
message(STATUS "- Iconv: FALSE")
endif ()
if (TARGET LibLZMA::LibLZMA)
message(STATUS "- LibLZMA: TRUE")
else ()
Expand Down
4 changes: 0 additions & 4 deletions libosmscout/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -403,10 +403,6 @@ if(MARISA_FOUND)
target_link_libraries(OSMScout ${MARISA_LIBRARIES})
endif()

if (TARGET Iconv::Iconv)
target_link_libraries(OSMScout Iconv::Iconv)
endif()

if(CMAKE_THREAD_LIBS_INIT)
target_link_libraries(OSMScout ${CMAKE_THREAD_LIBS_INIT})
endif()
Expand Down

0 comments on commit ec3471a

Please sign in to comment.