-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of std::format in Progress #1625
Conversation
Framstag
commented
Nov 16, 2024
- Added method variants using std::format for Progress
- Adapted code
- Added last version of WellScoutedRoute
- Added work in progress in OSMScout2 (and fixed search)
- Update to Visual Studio 2022 - Update to newer Android NDK
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Hi Tim. I don't look to specific changes yet. I just tried to compile this branch with Sailfish OS SDK and it fail. It is using GCC 10 right now, without I am sorry, but I do not see simple way, howto use these changes. Is there boost variant of format library? It is available somehow for gcc 10? |
@Karry: There seems to be https://github.com/fmtlib/fmt Do you have time to enhance the pull request and test it. Else I'll see around christmas time. |
I looked into detail. As I do not need Import tools on Sailfish OS, and it is the only place where Progress utility is used, I may easily exclude Progress.cpp and Progress.h from my build. It may work for me as a workaround until gcc 13 will be available for SFOS. I would guess that it will be in the middle of 2025. |
That sounds reasonable. I mentioned before that the importer in practice has other constraints and execution context than the rest of the libraries, since it will likely not run on the/a device. |