Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of std::format in Progress #1625

Merged
merged 4 commits into from
Dec 29, 2024
Merged

Conversation

Framstag
Copy link
Owner

  • Added method variants using std::format for Progress
  • Adapted code
  • Added last version of WellScoutedRoute
  • Added work in progress in OSMScout2 (and fixed search)

- Update to Visual Studio 2022
- Update to newer Android NDK
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Framstag
Copy link
Owner Author

Framstag commented Nov 16, 2024

@Karry, @janbar I would like to drop support for Ubunu 22.04, too. It would likely work with a custom gcc-13, but I do not want to spent the time to fix builds.

Also, is the newer Android NDK OK?

@Framstag
Copy link
Owner Author

Framstag commented Dec 2, 2024

@Karry , @janbar : Please, give some feedback!

@Karry
Copy link
Collaborator

Karry commented Dec 3, 2024

Hi Tim. I don't look to specific changes yet. I just tried to compile this branch with Sailfish OS SDK and it fail. It is using GCC 10 right now, without <format> support :-(

I am sorry, but I do not see simple way, howto use these changes. Is there boost variant of format library? It is available somehow for gcc 10?

@Framstag
Copy link
Owner Author

Framstag commented Dec 8, 2024

@Karry: There seems to be https://github.com/fmtlib/fmt Do you have time to enhance the pull request and test it. Else I'll see around christmas time.

@Karry
Copy link
Collaborator

Karry commented Dec 28, 2024

I looked into detail. As I do not need Import tools on Sailfish OS, and it is the only place where Progress utility is used, I may easily exclude Progress.cpp and Progress.h from my build.

It may work for me as a workaround until gcc 13 will be available for SFOS. I would guess that it will be in the middle of 2025.

@Framstag
Copy link
Owner Author

I looked into detail. As I do not need Import tools on Sailfish OS, and it is the only place where Progress utility is used, I may easily exclude Progress.cpp and Progress.h from my build.

It may work for me as a workaround until gcc 13 will be available for SFOS. I would guess that it will be in the middle of 2025.

That sounds reasonable. I mentioned before that the importer in practice has other constraints and execution context than the rest of the libraries, since it will likely not run on the/a device.

@Framstag Framstag merged commit 66bfe33 into master Dec 29, 2024
16 of 19 checks passed
@Framstag Framstag deleted the use-of-stdformat-in-Progress branch December 29, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants