Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all the db tables into the utf8mb4 charset and use it for MySQL connections #1254

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

zenovich
Copy link
Collaborator

  1. Convert all the db tables into the utf8mb4 charset
  2. Test that emojis are supported everywhere we insert/modify character data in the db

Fixes #1176

@zenovich zenovich requested a review from smadbe March 11, 2025 23:45
@zenovich zenovich force-pushed the utf8mb4 branch 3 times, most recently from 0671860 to 3fa41c0 Compare March 12, 2025 02:50
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (96f4673) to head (e9ad00f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1254   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          247       247           
  Lines        15283     15286    +3     
=========================================
+ Hits         15283     15286    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zenovich zenovich changed the title Convert all the db tables into the utf8mb4 charset Convert all the db tables into the utf8mb4 charset and use it for MySQL connections Mar 12, 2025
@zenovich zenovich merged commit 8e634bb into master Mar 12, 2025
4 checks passed
@zenovich zenovich deleted the utf8mb4 branch March 12, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 500 Conversion from collation utf8mb4_general_ci into utf8mb3_general_ci impossible for parameter
2 participants