Feature/update to angular 16 #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces scrollbar lib; - Fixes scroll logic for left menu; - fixes ts errors for primeng; - Updates zone.js;
Iloveall
force-pushed
the
feature/update-to-angular-16
branch
from
bb21c58 to
722c2f4
Compare
Iloveall
force-pushed
the
feature/update-to-angular-16
branch
from
722c2f4 to
ad55259
Compare
Iloveall
commented
Jun 23, 2023
| @@ -75,13 +74,13 @@ const DEFAULT_PERFECT_SCROLLBAR_CONFIG: PerfectScrollbarConfigInterface = { | |||
| ], | |||
| imports: [ | |||
| BrowserModule, | |||
| LetModule, | |||
| LetDirective, | |||
Iloveall
commented
Jun 23, 2023
| @@ -10,7 +10,7 @@ export interface BeforeUnloadComponent { | |||
| } | |||
|
|
|||
| @Injectable() | |||
| export class BeforeUnloadGuard implements CanDeactivate<BeforeUnloadComponent> { | |||
There was a problem hiding this comment.
Has been removed by cli as it deprecated
There was a problem hiding this comment.
but so, have you checked if this guard still work?
smadbe
reviewed
Jun 26, 2023
| @@ -10,7 +10,7 @@ export interface BeforeUnloadComponent { | |||
| } | |||
|
|
|||
| @Injectable() | |||
| export class BeforeUnloadGuard implements CanDeactivate<BeforeUnloadComponent> { | |||
There was a problem hiding this comment.
but so, have you checked if this guard still work?
| @@ -14,7 +14,7 @@ export interface PendingChangesComponent { | |||
| @Injectable({ | |||
| providedIn: 'root' | |||
| }) | |||
| export class PendingChangesGuard implements CanDeactivate<PendingChangesComponent>, OnDestroy { | |||
| export class PendingChangesGuard implements OnDestroy { | |||
| @@ -114,7 +114,7 @@ export class LayoutService implements OnDestroy { | |||
| @Injectable({ | |||
| providedIn: 'root' | |||
| }) | |||
| export class DefaultLayoutInitService implements CanActivate { | |||
| export class DefaultLayoutInitService { | |||
smadbe
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1368
Notes (out of scope, known isues, hints for reviewing code, ...) (optional)
Branch for test
I've realised that after design the scroll to nav item feature has been brokne. So I've fixed it (seems need to improve it after all our changes)
For some reason the primeng has removed the next generic type https://github.com/primefaces/primeng/commit/d3b00fcd6f7cfe30d1261fa893211062d9fa26f6#diff-d92d38111264028992d6cb71[…]9510846b1d3c44187c32ff979f3R13
Fixed with custom interface
Replaced deprecated scrollbar lib https://www.npmjs.com/package/ngx-perfect-scrollbar with https://www.npmjs.com/package/ngx-scrollbar
Test cases