Somewhat proper standalone timer implementation #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankvdStam
reviewed
Mar 3, 2024
FrankvdStam
reviewed
Mar 3, 2024
FrankvdStam
reviewed
Mar 3, 2024
|
Thanks a lot for your efforts, much appreciated. I have a few comments and it looks like I have to fiddle with the build a bit to merge this. |
FrankvdStam
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the standalone ER cli timer + blackscreen remover to a separate executable, while also adding support for DS 1-3 and Sekiro.
On start, it prompts the user for the game, after which it displays the timer (or error message) underneath it. Due to this, it also doesn't clear the entire console window anymore each time it updates, and instead updates the same line. In some cases, resizing the window too much might not work super well, but it generally behaved well on both Windows and Linux in my testing.
I also noticed that the time formatting in the previous code sticked to a 24 hour time format, after which it would loop around, which I fixed.
The use case for this is mostly Linux users speedrunning via Wine/Proton, since LiveSplit tends to be wonky there.