Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/timeout #80

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Feature/timeout #80

merged 10 commits into from
Mar 5, 2024

Conversation

aewag
Copy link
Member

@aewag aewag commented Nov 2, 2023 •
edited
Loading

Redesign of #79

@aewag aewag force-pushed the feature/timeout branch 4 times, most recently from ef785a6 to ebc9685 Compare November 2, 2023 13:10
@aewag aewag force-pushed the feature/timeout branch 2 times, most recently from 68bc7cc to 9ec3835 Compare November 2, 2023 16:18
@aewag aewag force-pushed the feature/timeout branch 2 times, most recently from d6a3ebe to 7876f05 Compare November 2, 2023 17:05
@aewag
controller: Rewrite timout mechanism
42e218e 
Kill the qemu process as it stalls the ARCHIE execution. After the qemu
process is killed, the qemu thread will terminate. As the pipes are
closed the python worker will terminate and write the received results
to the hdf5collector.
@aewag
Copy link
Member Author

aewag commented Nov 2, 2023 •
edited
Loading

With this timeout implementation the end_reason is not set (see the last three entries), as the qemu process is terminated early.

The results were generated with the stm32-timeout-wfi example.

$ h5dump output.hdf5 | less | grep -A10 end_reason
               ATTRIBUTE "end_reason" {
                  DATATYPE  H5T_STRING {
                     STRSIZE 12;          
                     STRPAD H5T_STR_NULLTERM;
                     CSET H5T_CSET_UTF8;
                     CTYPE H5T_C_S1;                
                  }                                 
                  DATASPACE  SCALAR                 
                  DATA {                            
                  (0): "not executed"               
                  }                                 
--                                                  
               ATTRIBUTE "end_reason" {
                  DATATYPE  H5T_STRING {
                     STRSIZE 12;          
                     STRPAD H5T_STR_NULLTERM;
                     CSET H5T_CSET_UTF8;
                     CTYPE H5T_C_S1;                
                  }                                 
                  DATASPACE  SCALAR                 
                  DATA {                            
                  (0): "not executed"               
                  }                                 
--                                                  
               ATTRIBUTE "end_reason" {
                  DATATYPE  H5T_STRING {
                     STRSIZE 12;          
                     STRPAD H5T_STR_NULLTERM;
                     CSET H5T_CSET_UTF8;
                     CTYPE H5T_C_S1;                
                  }                                 
                  DATASPACE  SCALAR                 
                  DATA {                            
                  (0): "not executed"               
                  }
--
         ATTRIBUTE "end_reason" {
            DATATYPE  H5T_STRING {
               STRSIZE 20;
               STRPAD H5T_STR_NULLTERM;
               CSET H5T_CSET_UTF8;
               CTYPE H5T_C_S1;
            }
            DATASPACE  SCALAR
            DATA {
            (0): "endpoint 134217814/1"
            }
--
         ATTRIBUTE "end_reason" {
            DATATYPE  H5T_STRING {
               STRSIZE 20;
               STRPAD H5T_STR_NULLTERM;
               CSET H5T_CSET_UTF8;
               CTYPE H5T_C_S1;
            }
            DATASPACE  SCALAR
            DATA {
            (0): "endpoint 134217834/1"
            }
--
            ATTRIBUTE "end_reason" {
               DATATYPE  H5T_STRING {
                  STRSIZE 1;
                  STRPAD H5T_STR_NULLTERM;
                  CSET H5T_CSET_UTF8;
                  CTYPE H5T_C_S1;
               }
               DATASPACE  NULL
               DATA {
               }
            }
--
            ATTRIBUTE "end_reason" {
               DATATYPE  H5T_STRING {
                  STRSIZE 1;
                  STRPAD H5T_STR_NULLTERM;
                  CSET H5T_CSET_UTF8;
                  CTYPE H5T_C_S1;
               }
               DATASPACE  NULL
               DATA {
               }
            }
--
            ATTRIBUTE "end_reason" {
               DATATYPE  H5T_STRING {
                  STRSIZE 1;
                  STRPAD H5T_STR_NULLTERM;
                  CSET H5T_CSET_UTF8;
                  CTYPE H5T_C_S1;
               }
               DATASPACE  NULL
               DATA {
               }
            }

@aewag aewag mentioned this pull request Nov 2, 2023
Merged
lukasauer
lukasauer approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@lukasauer lukasauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the todo messages, LGTM.

fault-readme.md Outdated Show resolved Hide resolved
controller.py Outdated Show resolved Hide resolved
controller.py Outdated Show resolved Hide resolved
@aewag aewag force-pushed the feature/timeout branch 2 times, most recently from 651d9b6 to c14f038 Compare March 5, 2024 09:07
@aewag aewag force-pushed the feature/timeout branch from c14f038 to ace83e0 Compare March 5, 2024 09:12
@aewag aewag force-pushed the feature/timeout branch from ace83e0 to e6239be Compare March 5, 2024 09:13
@aewag aewag merged commit a7615da into Fraunhofer-AISEC:master Mar 5, 2024
2 checks passed
This was referenced Mar 5, 2024
Closed
Closed
@aewag aewag deleted the feature/timeout branch March 5, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasauer lukasauer lukasauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aewag @lukasauer @berkayurun