Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coko 'Precedes' Evaluator #863

Merged
merged 19 commits into from
Sep 17, 2024
Merged

Coko 'Precedes' Evaluator #863

merged 19 commits into from
Sep 17, 2024

Conversation

CodingDepot
Copy link
Collaborator

This PR adds a Precedes evaluator to Coko that acts as an inverted Follows evaluator.
It finds instances of the right hand argument and checks whether it is preceded by the left hand argument.

This is useful when you want to state a condition for a function call to be verified.

@CodingDepot CodingDepot added the enhancement New feature or request label May 13, 2024
@CodingDepot CodingDepot requested a review from fwendland May 13, 2024 07:41
@CodingDepot CodingDepot self-assigned this May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (83170da) to head (1794b49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../backends/cpg/coko/evaluators/PrecedesEvaluator.kt 82.97% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #863      +/-   ##
============================================
+ Coverage     77.20%   77.35%   +0.15%     
- Complexity      250      259       +9     
============================================
  Files            59       60       +1     
  Lines          1882     1930      +48     
  Branches        265      272       +7     
============================================
+ Hits           1453     1493      +40     
- Misses          308      312       +4     
- Partials        121      125       +4     
Flag Coverage Δ
unittests 77.35% <83.33%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodingDepot CodingDepot marked this pull request as ready for review May 15, 2024 07:38
@fwendland fwendland merged commit c14fbcd into main Sep 17, 2024
6 checks passed
@fwendland fwendland deleted the rh/test-coko branch September 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants