-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persisting to Neo4J without OGM #1893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress
oxisto
force-pushed
the
neo4j-without-ogm
branch
from
December 11, 2024 14:18
684b2a6
to
b330d57
Compare
konradweiss
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes and discussion is still needed here. In some places I wonder if we can use introspectionfunctionality where we now use hardcoded propertyTypes or relationships
cpg-neo4j/src/main/kotlin/de/fraunhofer/aisec/cpg_vis_neo4j/Application.kt
Outdated
Show resolved
Hide resolved
cpg-neo4j/src/main/kotlin/de/fraunhofer/aisec/cpg_vis_neo4j/Application.kt
Show resolved
Hide resolved
cpg-neo4j/src/main/kotlin/de/fraunhofer/aisec/cpg/persistence/Neo4J.kt
Outdated
Show resolved
Hide resolved
cpg-neo4j/src/main/kotlin/de/fraunhofer/aisec/cpg/persistence/Neo4J.kt
Outdated
Show resolved
Hide resolved
cpg-neo4j/src/main/kotlin/de/fraunhofer/aisec/cpg/persistence/Common.kt
Outdated
Show resolved
Hide resolved
cpg-neo4j/src/main/kotlin/de/fraunhofer/aisec/cpg/persistence/Common.kt
Outdated
Show resolved
Hide resolved
cpg-neo4j/src/main/kotlin/de/fraunhofer/aisec/cpg/persistence/Common.kt
Outdated
Show resolved
Hide resolved
konradweiss
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to build a lightweight persistence layer to Neo4J without the Neo4J OGM which causes immense problems (recursion depth, out of memory, etc.).
In the long run we might be able to get rid of the neo4j-ogm, which would allow us to re-design the node classes a little bit because we are not restricted by the OGM anymore.
Edge
edges