Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new Overlay and Concept nodes to the graph. #1897

Merged
merged 16 commits into from
Dec 17, 2024
Merged

Conversation

maximiliankaul
Copy link
Contributor

@maximiliankaul maximiliankaul commented Dec 12, 2024

Preparation for mk/concepts This are the cpg-core affecting changes.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.04%. Comparing base (1f16d58) to head (7f77fc0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/cpg/graph/edges/collections/EdgeSingletonList.kt 25.00% 8 Missing and 1 partial ⚠️
...raunhofer/aisec/cpg/graph/edges/overlay/Overlay.kt 90.90% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../main/kotlin/de/fraunhofer/aisec/cpg/graph/Node.kt 87.50% <100.00%> (+0.44%) ⬆️
...otlin/de/fraunhofer/aisec/cpg/graph/OverlayNode.kt 100.00% <100.00%> (ø)
.../de/fraunhofer/aisec/cpg/graph/concepts/Concept.kt 100.00% <100.00%> (ø)
...e/fraunhofer/aisec/cpg/graph/concepts/Operation.kt 100.00% <100.00%> (ø)
...raunhofer/aisec/cpg/graph/edges/overlay/Overlay.kt 90.90% <90.90%> (ø)
...c/cpg/graph/edges/collections/EdgeSingletonList.kt 56.25% <25.00%> (+2.54%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@konradweiss konradweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some renaming and the hierarchy change suggestion this is what I had in mind.

@oxisto oxisto requested a review from peckto as a code owner December 17, 2024 13:51
Copy link
Collaborator

@konradweiss konradweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only remarks I have is that I would prefer the edges to go from the overlay node to the underlay node, but that is more because it was always like this in my imagination. And then we would need a different edge label so it is not really something we have to change for this PR.

@oxisto
Copy link
Member

oxisto commented Dec 17, 2024

LGTM. The only remarks I have is that I would prefer the edges to go from the overlay node to the underlay node, but that is more because it was always like this in my imagination. And then we would need a different edge label so it is not really something we have to change for this PR.

I can just switch the direction, if you want

@oxisto
Copy link
Member

oxisto commented Dec 17, 2024

LGTM. The only remarks I have is that I would prefer the edges to go from the overlay node to the underlay node, but that is more because it was always like this in my imagination. And then we would need a different edge label so it is not really something we have to change for this PR.

I can just switch the direction, if you want

AH, no that doesn't work. It needs to be outgoing from an AST node, otherwise it will not end up in the persisted graph. I will keep it as is for now.

@oxisto
Copy link
Member

oxisto commented Dec 17, 2024

Screenshot 2024-12-17 at 20 32 19

Nodes can also have multiple overlay nodes now, but an overlay can only have one underlying node.

@oxisto oxisto enabled auto-merge (squash) December 17, 2024 19:38
@oxisto oxisto merged commit 698937e into main Dec 17, 2024
2 checks passed
@oxisto oxisto deleted the mk/core-concepts branch December 17, 2024 19:49
@oxisto oxisto linked an issue Dec 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a generic Concept node
3 participants