Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisting literal values more conservativly #1907

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Dec 18, 2024

Fixes issues with python interface files

Fixes issues with python interface files
Copy link
Collaborator

@konradweiss konradweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, If we see that there is a type we have not considered in this distinction that is not supposed to run into the default case, we can then add that distinction there.

@konradweiss konradweiss merged commit e39f15d into main Dec 18, 2024
2 checks passed
@konradweiss konradweiss deleted the literal-converter branch December 18, 2024 08:40
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.03%. Comparing base (698937e) to head (b5388f9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../aisec/cpg/graph/statements/expressions/Literal.kt 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...tlin/de/fraunhofer/aisec/cpg/persistence/Common.kt 88.76% <ø> (+1.95%) ⬆️
.../aisec/cpg/graph/statements/expressions/Literal.kt 77.77% <66.66%> (-8.89%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants