Add On Import Translation of Python Files in Include Path #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the interfac file is a/b.py or a/b.pyi. or if the import statement looks like from a import b
…ing imports on a component level
…a condition to decide when the on demand inclusion should be performed
konradweiss
changed the title
…hofer-AISEC/cpg into feature/import-external-interfaces
maximiliankaul
requested changes
Jan 23, 2025
| @@ -140,15 +142,24 @@ private constructor( | |||
| result: TranslationResult, | |||
| ): Set<LanguageFrontend<*, *>> { | |||
| val usedFrontends = mutableSetOf<LanguageFrontend<*, *>>() | |||
|
|
|||
| val externalSources: MutableList<File> = mutableListOf() | |||
There was a problem hiding this comment.
Can we please have some doc here? What are these variables used for?
| return usedFrontends | ||
| } | ||
|
|
||
| private fun extractConfiguredSources(path: Path): MutableList<File> { | ||
| val rootFile = path.toFile() | ||
| return if (rootFile.exists()) |
There was a problem hiding this comment.
Please refactor this code. Add some { as a start.
| } | ||
| .toMutableList() | ||
|
|
||
| val importRe = "(?m)^(?:from[ ]+(\\S+)[ ]+)?import[ ]+(\\S+)[ ]*\$".toRegex() |
There was a problem hiding this comment.
I object having this regex here.
- It's not documented.
- I don't like parsing the sources manually with a regex -> can't we use the
ast.parseresult for this? - Can we please name groups, if we have to use a regex? This would make it much easier to understand what's going on.
- What about
import foowithout thefrompart? - What about
asin the import?
| importRe.findAll(source.readText()).forEach { imp -> | ||
|
|
||
| // Only try to find file containing imports if we did not process this import so far | ||
| if (!processedImports.contains(imp.groupValues.get(0))) { |
There was a problem hiding this comment.
I don't think this approach works. An from foo ... import can refer to different imports, depending on the location of the file you're parsing here.
…extLanguageFrontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a preprocessing function to all languages that is supposed to return files located in the includePaths that are supposed to be analyzed under their own component.
The current implementation for python identifies which file in the import paths should be used to fulfill which import statement and then recursively resolves additional imports in that file.