Revamp of node system and injecting ctx everywhere
#2114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding ctx to type
oxisto
changed the title
ctx on scopes and typesctx everywhere
oxisto
force-pushed
the
cb/remove-ast-placement-by-add-declaration
branch
from
065865f to
bf0a449
Compare
Base automatically changed from
cb/remove-ast-placement-by-add-declaration
to
main
March 11, 2025 11:35
|
Closed in favour of #2126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a HUGE PR and I might need to split this into smaller pieces, but I am not sure if this is possible. Several things are happening here
Introduction of several intermediate
Nodesub-classes:Not all our nodes need complete access to all graph edges (such as the EOG, etc.). For example, currently it is possible to set EOG edges on types, scope and language nodes, which does not make sense at all. There, this PR introduces three new node classes:
EvaluatedNodewhich is the basis for the EOG,DataflowNode, which extends the EOG node and adds dataflow-related edges and finallyAstNodewhich is the basis of all nodes that belong to the AST. (Currently, types are still AST nodes, but I want to entangle this as well).