Skip to content

Conversation

mosfet80
Copy link

fix:
warning: unused variable ‘bool1’ [-Wunused-variable]
warning: unused variable ‘bool2’ [-Wunused-variable]

Clean code

fix:
 warning: unused variable ‘bool1’ [-Wunused-variable]
 warning: unused variable ‘bool2’ [-Wunused-variable]

Clean code
@schmidtw
Copy link

schmidtw commented Sep 6, 2025

@chennes is there someone who can/should review this PR & merge it?

@chennes
Copy link
Member

chennes commented Sep 6, 2025

I generally leave the reviews of Ondsel Solver of @aiksiongkoh, but basically anyone can review this one.

@aiksiongkoh
Copy link

The comments are actual code commented out for future implementation.
I would like to keep them to remind me of to-dos.
Is there a recommended way to leave to-dos in the code?

@schmidtw
Copy link

schmidtw commented Sep 7, 2025

In other projects I'm involved in folks have branches with associated feature code there. It is still close the the main code but doesn't clutter things. Issues are another combination where the feature idea can be written up, then the assorted permalinks to the code prior to removal - or the branch can be made so it's easy to understand the feature/where things go.

@aiksiongkoh
Copy link

Sorry. It is not clear what I need to do. Is there an example for me to follow? Thanks.

@schmidtw
Copy link

schmidtw commented Sep 9, 2025

@mosfet80 would you be willing to reduce your PR so only the warnings are fixed & the commented code is left alone for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants