Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiboken2: update formula to include py module .pth file #449

Closed
wants to merge 1 commit into from

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Dec 6, 2023

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch ipatch self-assigned this Dec 6, 2023
@ipatch ipatch force-pushed the shiboken.update branch 4 times, most recently from 43eece2 to 35f97e9 Compare December 7, 2023 20:12
@ipatch
Copy link
Collaborator Author

ipatch commented Dec 7, 2023

build fails on catalina explicitly defining the below cmake variable but did not cause build failures on big sur and newer macos versions 🤨

"-DPYTHON_EXECUTABLE=#{python3}",

got the below output using cmake on macos catalina,

-- Using Qt 5
-- Found PythonInterp: /usr/local/opt/[email protected]/bin/python3
-- Found PythonLibs: /usr/local/opt/[email protected]/Frameworks/Python.framework/Versions/3.11/lib/libpython3.11.dylib (found version "3.11.0")
-- PYTHON_ARCH:
-- CLANG: /usr/local/opt/llvm, /usr/local/opt/llvm/lib/libclang.dylib detected by LLVM_INSTALL_DIR
-- Looking for C++ include clang-c/Index.h
-- Looking for C++ include clang-c/Index.h - found
CMake Error at CMakeLists.txt:51 (message):
  Could not identify shiboken version.  Error:


-- Configuring incomplete, errors occurred!
See also "/tmp/shiboken2A5.15.11-20231207-22175-2hbsic/pyside-setup-opensource-src-5.15.11/build/CMakeFiles/CMakeOutput.log".
-- Cache values
BUILD_TESTS:BOOL=ON
CLANG_LIBRARY:FILEPATH=/usr/local/opt/llvm/lib/libclang.dylib
CMAKE_BUILD_TYPE:STRING=Release
CMAKE_INSTALL_PREFIX:PATH=/usr/local/Cellar/[email protected]/5.15.11_4
CMAKE_OSX_ARCHITECTURES:STRING=
CMAKE_OSX_DEPLOYMENT_TARGET:STRING=
CMAKE_OSX_SYSROOT:PATH=/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk
DISABLE_DOCSTRINGS:BOOL=OFF
ENABLE_ICECC:BOOL=OFF
Qt5Core_DIR:PATH=/usr/local/opt/qt@5/lib/cmake/Qt5Core
Qt5_DIR:PATH=/usr/local/opt/qt@5/lib/cmake/Qt5
USE_PYTHON_VERSION:BOOL=OFF

@ipatch ipatch force-pushed the shiboken.update branch 4 times, most recently from 90613aa to 5298b76 Compare December 7, 2023 22:39
@ipatch ipatch added the pr-pull label Dec 8, 2023
@github-actions github-actions bot closed this in 145532b Dec 8, 2023
@ipatch ipatch mentioned this pull request Dec 10, 2023
@ipatch ipatch deleted the shiboken.update branch December 28, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant