Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fc_bundle: add missing py module six #519

Closed

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Jun 5, 2024

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch ipatch force-pushed the fc_bundle-add.missing.py.module.six branch from db168d6 to d3ab6d7 Compare June 5, 2024 19:45
@ipatch
Copy link
Collaborator Author

ipatch commented Jun 5, 2024

inconsistent results with brew style

https://github.com/orgs/Homebrew/discussions/5426

@ipatch ipatch self-assigned this Jun 5, 2024
@ipatch
Copy link
Collaborator Author

ipatch commented Jun 5, 2024

below ci issues / errors seem to be false positives.

Warning: 1 failed step ignored!
brew linkage --cached --test --strict freecad/freecad/[email protected]_py310

@github-actions github-actions bot closed this in 1f45fbd Jun 5, 2024
@ipatch ipatch deleted the fc_bundle-add.missing.py.module.six branch June 5, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant