Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]_py310: new formula #520

Closed
wants to merge 1 commit into from

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Jun 6, 2024

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch ipatch self-assigned this Jun 6, 2024
@ipatch
Copy link
Collaborator Author

ipatch commented Jun 6, 2024

CMake Error at /home/capin/homebrew/Cellar/cmake/3.29.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python3 (missing: Python3_EXECUTABLE Python3_INCLUDE_DIRS
  Python3_LIBRARIES Interpreter Development Development.Module
  Development.Embed)
Call Stack (most recent call first):
  /home/capin/homebrew/Cellar/cmake/3.29.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /home/capin/homebrew/Cellar/cmake/3.29.3/share/cmake/Modules/FindPython/Support.cmake:3867 (find_package_handle_standard_args)
  /home/capin/homebrew/Cellar/cmake/3.29.3/share/cmake/Modules/FindPython3.cmake:545 (include)
  cMake/FreeCAD_Helpers/SetupPython.cmake:4 (find_package)
  CMakeLists.txt:54 (SetupPython)


-- Configuring incomplete, errors occurred!
-- Cache values

building locally on my arch linux install i get the above cmake configure error

@ipatch
Copy link
Collaborator Author

ipatch commented Jun 6, 2024

looks like existing python patch will not work,

==> Patching
cp -p /home/capin/.cache/Homebrew/downloads/049296b0ae1a7db83e18846546e9b8524541a08e1ec87d5d3d6e168d2fe29278--freecad-0.20.2-setup-python-cmake.patch /opt/tmp/homebrew/freecadA0.21.2_py310--patch-20240606-198803-l7c687/freecad-0.20.2-setup-python-cmake.patch
==> Applying freecad-0.20.2-setup-python-cmake.patch
patch -g 0 -f -p1 -i /opt/tmp/homebrew/freecadA0.21.2_py310--patch-20240606-198803-l7c687/freecad-0.20.2-setup-python-cmake.patch
patching file cMake/FreeCAD_Helpers/SetupPython.cmake
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file cMake/FreeCAD_Helpers/SetupPython.cmake.rej

@ipatch
Copy link
Collaborator Author

ipatch commented Jun 6, 2024

update formula file to use new cmake python related vars,

Python3_EXECUTABLE 
Python3_INCLUDE_DIRS
Python3_LIBRARIES

@ipatch
Copy link
Collaborator Author

ipatch commented Jun 6, 2024

current cmake configure error with github hosted ubuntu runner, and getting the same error with the macos runner.

-- Checking for one of the modules 'hdf5-serial'
  -- Unable to determine HDF5 C flags from HDF5 wrapper.
  CMake Error at /home/linuxbrew/.linuxbrew/Cellar/cmake/3.29.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find HDF5 (missing: HDF5_LIBRARIES HDF5_HL_LIBRARIES) (found
    version "1.14.3")
  Call Stack (most recent call first):
    /home/linuxbrew/.linuxbrew/Cellar/cmake/3.29.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
    /home/linuxbrew/.linuxbrew/Cellar/cmake/3.29.4/share/cmake/Modules/FindHDF5.cmake:1025 (find_package_handle_standard_args)
    cMake/FreeCAD_Helpers/SetupSalomeSMESH.cmake:94 (find_package)
    CMakeLists.txt:67 (SetupSalomeSMESH)
  -- Configuring incomplete, errors occurred!

@ipatch ipatch force-pushed the [email protected]_py310 branch 2 times, most recently from ed89957 to f2d97ae Compare June 7, 2024 17:20
@ipatch
Copy link
Collaborator Author

ipatch commented Jun 7, 2024

current build error on my arch linux box, running brew install [email protected]_py310 -v -s

[749/4963] /home/capin/homebrew/opt/llvm/bin/clang++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_DATE_TIME_DYN_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PP_VARIADICS=1 -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DBUILD_ADDONMGR -DCMAKE_BUILD_TYPE=\"RelWithDebInfo\" -DFreeCADGui_EXPORTS -DHAVE_CONFIG_H -DHAVE_PYSIDE2 -DHAVE_SHIBOKEN2 -DNDEBUG -DPYCXX_6_2_COMPATIBILITY -DPYSIDE_QML_SUPPORT=1 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_SVG_LIB -DQT_UITOOLS_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -D_OCC64 -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/FreeCADGui_autogen/include -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui/Quarter -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui/.. -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/.. -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/Language -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/propertyeditor -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/TaskView -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/Quarter -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/DAGView -I/home/capin/homebrew/opt/eigen/include/eigen3 -I/home/capin/homebrew/opt/coin3d_py310/include -I/home/capin/homebrew/opt/xerces-c/include -I/home/capin/homebrew/opt/zlib/include -I/home/capin/homebrew/opt/[email protected]_py310/include/PySide2/QtCore -I/home/capin/homebrew/opt/[email protected]_py310/include/PySide2/QtGui -I/home/capin/homebrew/opt/[email protected]_py310/include/PySide2/QtWidgets -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/_deps/fmt-src/include -isystem /home/capin/homebrew/Cellar/boost/1.85.0/include -isystem /home/capin/homebrew/opt/[email protected]/include/python3.10 -isystem /home/capin/homebrew/opt/qt@5/include -isystem /home/capin/homebrew/opt/qt@5/include/QtCore -isystem /home/capin/homebrew/opt/qt@5/./mkspecs/linux-g++ -isystem /home/capin/homebrew/opt/qt@5/include/QtWidgets -isystem /home/capin/homebrew/opt/qt@5/include/QtGui -isystem /home/capin/homebrew/opt/mesa/include -isystem /home/capin/homebrew/opt/qt@5/include/QtOpenGL -isystem /home/capin/homebrew/opt/qt@5/include/QtPrintSupport -isystem /home/capin/homebrew/opt/qt@5/include/QtSvg -isystem /home/capin/homebrew/opt/qt@5/include/QtNetwork -isystem /home/capin/homebrew/opt/qt@5/include/QtUiTools -isystem /home/capin/homebrew/opt/[email protected]_py310/include/shiboken2 -isystem /home/capin/homebrew/opt/[email protected]_py310/include/PySide2 -isystem /home/capin/homebrew/opt/qt@5/include/QtXml -Wall -Wextra -Wpedantic -Wno-write-strings  -Wno-undefined-var-template -O2 -g -DNDEBUG -std=gnu++17 -fPIC -I/home/capin/homebrew/opt/open-mpi/include -fPIC -MD -MT src/Gui/CMakeFiles/FreeCADGui.dir/PreferencePackManager.cpp.o -MF src/Gui/CMakeFiles/FreeCADGui.dir/PreferencePackManager.cpp.o.d -o src/Gui/CMakeFiles/FreeCADGui.dir/PreferencePackManager.cpp.o -c /opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui/PreferencePackManager.cpp
FAILED: src/Gui/CMakeFiles/FreeCADGui.dir/PreferencePackManager.cpp.o
/home/capin/homebrew/opt/llvm/bin/clang++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_DATE_TIME_DYN_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PP_VARIADICS=1 -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DBUILD_ADDONMGR -DCMAKE_BUILD_TYPE=\"RelWithDebInfo\" -DFreeCADGui_EXPORTS -DHAVE_CONFIG_H -DHAVE_PYSIDE2 -DHAVE_SHIBOKEN2 -DNDEBUG -DPYCXX_6_2_COMPATIBILITY -DPYSIDE_QML_SUPPORT=1 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_SVG_LIB -DQT_UITOOLS_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -D_OCC64 -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/FreeCADGui_autogen/include -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui/Quarter -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui/.. -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/.. -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/Language -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/propertyeditor -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/TaskView -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/Quarter -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/src/Gui/DAGView -I/home/capin/homebrew/opt/eigen/include/eigen3 -I/home/capin/homebrew/opt/coin3d_py310/include -I/home/capin/homebrew/opt/xerces-c/include -I/home/capin/homebrew/opt/zlib/include -I/home/capin/homebrew/opt/[email protected]_py310/include/PySide2/QtCore -I/home/capin/homebrew/opt/[email protected]_py310/include/PySide2/QtGui -I/home/capin/homebrew/opt/[email protected]_py310/include/PySide2/QtWidgets -I/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/build/_deps/fmt-src/include -isystem /home/capin/homebrew/Cellar/boost/1.85.0/include -isystem /home/capin/homebrew/opt/[email protected]/include/python3.10 -isystem /home/capin/homebrew/opt/qt@5/include -isystem /home/capin/homebrew/opt/qt@5/include/QtCore -isystem /home/capin/homebrew/opt/qt@5/./mkspecs/linux-g++ -isystem /home/capin/homebrew/opt/qt@5/include/QtWidgets -isystem /home/capin/homebrew/opt/qt@5/include/QtGui -isystem /home/capin/homebrew/opt/mesa/include -isystem /home/capin/homebrew/opt/qt@5/include/QtOpenGL -isystem /home/capin/homebrew/opt/qt@5/include/QtPrintSupport -isystem /home/capin/homebrew/opt/qt@5/include/QtSvg -isystem /home/capin/homebrew/opt/qt@5/include/QtNetwork -isystem /home/capin/homebrew/opt/qt@5/include/QtUiTools -isystem /home/capin/homebrew/opt/[email protected]_py310/include/shiboken2 -isystem /home/capin/homebrew/opt/[email protected]_py310/include/PySide2 -isystem /home/capin/homebrew/opt/qt@5/include/QtXml -Wall -Wextra -Wpedantic -Wno-write-strings  -Wno-undefined-var-template -O2 -g -DNDEBUG -std=gnu++17 -fPIC -I/home/capin/homebrew/opt/open-mpi/include -fPIC -MD -MT src/Gui/CMakeFiles/FreeCADGui.dir/PreferencePackManager.cpp.o -MF src/Gui/CMakeFiles/FreeCADGui.dir/PreferencePackManager.cpp.o.d -o src/Gui/CMakeFiles/FreeCADGui.dir/PreferencePackManager.cpp.o -c /opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui/PreferencePackManager.cpp
/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui/PreferencePackManager.cpp:224:42: error: no member named 'copy_option' in namespace 'boost::filesystem'; did you mean 'copy_options'?
  224 |     fs::copy_file(path, cfgFilename, fs::copy_option::overwrite_if_exists);
      |                                      ~~~~^~~~~~~~~~~
      |                                          copy_options
/home/capin/homebrew/Cellar/boost/1.85.0/include/boost/filesystem/operations.hpp:44:12: note: 'copy_options' declared here
   44 | enum class copy_options : unsigned int
      |            ^
/opt/tmp/homebrew/freecadA0.21.2_py310-20240607-504401-y3zr1e/FreeCAD-0.21.2/src/Gui/PreferencePackManager.cpp:224:55: error: no member named 'overwrite_if_exists' in 'boost::filesystem::copy_options'; did you mean 'overwrite_existing'?
  224 |     fs::copy_file(path, cfgFilename, fs::copy_option::overwrite_if_exists);
      |                                      ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
      |                                                       overwrite_existing
/home/capin/homebrew/Cellar/boost/1.85.0/include/boost/filesystem/operations.hpp:50:5: note: 'overwrite_existing' declared here
   50 |     overwrite_existing = 1u << 1u,      // Overwrite existing file
      |     ^
2 errors generated.

similar / related issues due to api changes in boost version 1.85.0

dogecoin/dogecoin#3548

monero-project/monero#9304

@ipatch
Copy link
Collaborator Author

ipatch commented Jun 8, 2024

the below commit should fix the issues related to boost v1.85.0 api changes.

ff35908

@ipatch ipatch added the pr-pull label Jun 9, 2024
@ipatch
Copy link
Collaborator Author

ipatch commented Jun 9, 2024

am able to build this formula ie. [email protected]_py310 on my local arch linux install, but reasons i fully do not understand the ubuntu ci build keeps failing.

@github-actions github-actions bot closed this in 6f28aa3 Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant