[v1.0.0] Bump to PHP 8.1 and adjust the code. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the phpunit config for the new version.
…that should be private. Adjust formatting.
…ently supported / work in this library as it stands.
…d return types indicate the type. Ignore it for now.
Codecov Report
@@ Coverage Diff @@
## 1.0 #57 +/- ##
============================================
+ Coverage 85.10% 86.77% +1.66%
+ Complexity 3660 1795 -1865
============================================
Files 256 128 -128
Lines 9472 5178 -4294
============================================
- Hits 8061 4493 -3568
+ Misses 1411 685 -726
... and 128 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… from ASN1. We will stay at level 8 for now. Also fix various static analysis issues.
Use named params in many spots / fix formatting to make the code easier to follow.
…. Fix a few spots I missed types in.
|
Merging this in, as I will not be tagging 1.0 for a while, though the branch will exist. I still want to add strict types to all classes as well and do other clean up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an eventual 1.0.0 release, I'm dropping support for old PHP versions. Since PHP 7.4 is EOL and 8.0 is going EOL this November, I'm making the decision to just use PHP 8.1.
As part of this, I'm updating the code to use actual return types / property types wherever possible. I've also re-evaluated visibility for many properties. This is a large change, but there is also good code coverage with both unit and integration tests, so I feel comfortable with it.
#50
#48