Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.0] More code clean-up since PHP update. #62

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

ChadSikorra
Copy link
Contributor

@ChadSikorra ChadSikorra commented Jun 4, 2023

This is a set of miscellaneous code clean-up items:

  • Redundant phpdoc.
  • Unused variables.
  • Unnecessary property initialization.
  • Missed types in params.
  • Usage of null-safe operator.
  • Typos.

#50

* Un-needed phpdoc.
* Unused variables.
* Unnecessary property initialization.
* Missed types in params.
* Usage of null-safe operator.
* Typos.
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #62 (6dcfc6e) into 1.0 (c0c7e82) will not change coverage.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##                1.0      #62   +/-   ##
=========================================
  Coverage     86.82%   86.82%           
+ Complexity     1801     1798    -3     
=========================================
  Files           128      128           
  Lines          5214     5214           
=========================================
  Hits           4527     4527           
  Misses          687      687           
Impacted Files Coverage Δ
src/FreeDSx/Ldap/Control/Control.php 80.00% <ø> (ø)
src/FreeDSx/Ldap/Entry/Attribute.php 97.36% <ø> (ø)
src/FreeDSx/Ldap/LdapClient.php 95.83% <ø> (ø)
src/FreeDSx/Ldap/LdapServer.php 72.41% <ø> (ø)
src/FreeDSx/Ldap/Protocol/LdapMessage.php 86.20% <ø> (ø)
src/FreeDSx/Ldap/Protocol/ReferralContext.php 100.00% <ø> (ø)
...ocol/ServerProtocolHandler/ServerPagingHandler.php 91.11% <0.00%> (ø)
...DSx/Ldap/Server/ServerRunner/PcntlServerRunner.php 0.00% <ø> (ø)
src/FreeDSx/Ldap/Server/Token/AnonToken.php 100.00% <ø> (ø)
src/FreeDSx/Ldap/Server/Token/BindToken.php 100.00% <ø> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChadSikorra ChadSikorra merged commit da79f79 into FreeDSx:1.0 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant