[1.0.0] Support cancelling search / sync operations. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.0 #71 +/- ##
============================================
- Coverage 86.90% 86.48% -0.43%
- Complexity 2093 2116 +23
============================================
Files 151 155 +4
Lines 6432 6517 +85
============================================
+ Hits 5590 5636 +46
- Misses 842 881 +39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChadSikorra
force-pushed
the
v1-cancel_operation
branch
8 times, most recently
from
5a15b6f to
18973dc
Compare
… operations that make sense to have special logic for handling a cancellation. Add a cancellation strategy for search based requests. They can either choose to "continue" to process messages received until the server acknowledges the cancellation, or they can choose to "stop" (the default) and ignore any subsequent messages received from the point of cancellation to the point where the server acknowledges it. I can see the "stop" strategy being useful in normal search contexts, while a "continue" would likely be desired in a sync operation search (as you would not want to ignore sync data).
ChadSikorra
force-pushed
the
v1-cancel_operation
branch
from
18973dc to
70f73d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some special handling for cancelling search / sync operations. These are arguably the only requests it makes practical sense to support handling for cancellations. As in general, it makes little sense to try to cancel a request that will not have multiple responses / is not long running. The usage of cancellations is also somewhat questionable with paging being widely supported. However, it does make some sense in the context of a sync operation. As cancellation allows ending it in a more graceful manner.
#50