Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.0] Refactor how server binds are handled / adjust interfaces. #79

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

ChadSikorra
Copy link
Contributor

This cleans-up the way binds are handled by the server. It makes it easier to test in the classes that use it and gets rid of a factory class.

#50

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #79 (72ac890) into 1.0 (3facd95) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                1.0      #79   +/-   ##
=========================================
  Coverage     87.89%   87.89%           
- Complexity     2143     2145    +2     
=========================================
  Files           156      156           
  Lines          6650     6651    +1     
=========================================
+ Hits           5845     5846    +1     
  Misses          805      805           
Files Changed Coverage Δ
...eeDSx/Ldap/Protocol/Bind/VersionValidatorTrait.php 100.00% <ø> (ø)
src/FreeDSx/Ldap/Protocol/Authenticator.php 100.00% <100.00%> (ø)
src/FreeDSx/Ldap/Protocol/Bind/AnonymousBind.php 76.47% <100.00%> (ø)
src/FreeDSx/Ldap/Protocol/Bind/SimpleBind.php 84.00% <100.00%> (ø)
...rc/FreeDSx/Ldap/Protocol/ServerProtocolHandler.php 98.98% <100.00%> (-0.02%) ⬇️
src/FreeDSx/Ldap/Server/ServerProtocolFactory.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChadSikorra ChadSikorra force-pushed the v1-interface_refactor branch from a2f904d to 72ac890 Compare August 11, 2023 14:41
@ChadSikorra ChadSikorra marked this pull request as ready for review August 11, 2023 14:45
@ChadSikorra ChadSikorra merged commit d9c7ae4 into FreeDSx:1.0 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant