Redesigned and improved the Notifications page #1548
+3,340
−1,816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMDJafari
changed the title
davidmz
reviewed
Aug 25, 2022
config/default.js
Outdated
| @@ -6,7 +6,7 @@ const DAY_IN_MILLISECONDS = 1000 * 60 * 60 * 24; | |||
|
|
|||
| export default { | |||
| api: { | |||
| root: 'https://candy.freefeed.net', | |||
| root: 'https://freefeed.net', | |||
There was a problem hiding this comment.
You should not change the default settings, they purposely specify a stage instance (candy).
For testing purposes, you can override them in the config.json file at the root of the repository. It will not be included in the commit by .gitignore.
|
Yeah, you're right but I have a problem with Vercel deployment that needs
this (and other) configs to work properly due to connecting to my repo
directly. For now, I solved it by creating another branch till I find a
better solution.
…On Thu, Aug 25, 2022, 10:27 PM David Mzareulyan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In config/default.js
<#1548 (comment)>
:
> @@ -6,7 +6,7 @@ const DAY_IN_MILLISECONDS = 1000 * 60 * 60 * 24;
export default {
api: {
- root: 'https://candy.freefeed.net',
+ root: 'https://freefeed.net',
You should not change the default settings, they purposely specify a stage
instance (candy).
For testing purposes, you can override them in the config.json file at the
root of the repository. It will not be included in the commit by .gitignore.
—
Reply to this email directly, view it on GitHub
<#1548 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP6S7PDACMFWWUS5SK7VYNTV26X2FANCNFSM57QZLIFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…fork" This reverts commit c846deb.
stick navigation bar to the bottom of screen for mobile devices with new icons and fix both them for navigation bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigned and improved the Notifications Page & some minor fixes
https://github.com/MMDJafari/freefeed-react-client/tree/notification-page
Update: Added Inline Video Player & some minor fixes
https://github.com/MMDJafari/freefeed-react-client/tree/notification-page-%26-inline-video-player
Update: Moved the Navigation Bar to the bottom of the screen for mobile devices & some minor fixes
https://github.com/MMDJafari/freefeed-react-client/tree/notification-page-%26-inline-video-player-%26-navigation-bar
Live Test: https://freefeed.vercel.app
Screenshots:
Mobile:
Desktop:
