Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewDescription default Timestamp value should be OPC UA TimeBase #1779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cacamille3
Copy link

OPC UA TimeBase is 1601-01-01 UTC
Otherwise, some OPC UA Server not supporting this Browse optional feature might return BadViewTimestampInvalid when the Timestamp is not set to null

#654

OPC UA TimeBase is 1601-01-01 UTC
Otherwise, some OPC UA Server not supporting this Browse optional feature might return BadViewTimestampInvalid when the Timestamp is not set to null
@cziebuhr
Copy link
Contributor

You can't just do changes in uaprotocol_auto.py, as it gets autogenerated.

https://reference.opcfoundation.org/Core/Part6/v105/docs/5.1 has a table with default values per built-in type. I think it makes sense to use all those defaults in all places where default values gets created:

  • common/structures104.py:get_default_value
    • Boolean: "False" (instead of "True")
    • DateTime: "FILETIME_EPOCH_AS_UTC_DATETIME"
  • ua/uatypes.py:get_default_value
    • ByteString: null (instead of b"")
    • DateTime: FILETIME_EPOCH_AS_UTC_DATETIME

(List may not be complete)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants