Add typing metadata and include py.typed in sdist
#1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit marks the package as typed in the classifiers and ensures `py.typed` is included in the source distribution. This improves compatibility with type checkers and enforces better type safety for users.
|
the main issue is that typing is far from perfect. but we can try again to fix it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted this pull request to enhance the opcua-asyncio library's compatibility with static type checkers like mypy. While running mypy in my project, I encountered the following error:
This issue arises because mypy requires either inline type annotations or the presence of a py.typed file in the package to recognize it as typed. By adding the py.typed file and including it in the source distribution (sdist), we ensure that mypy and other type checkers can properly analyze the asyncua module, thereby improving the developer experience and code reliability.