Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect monitored item trigger (DataChangeFilter) #579

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

draity
Copy link

@draity draity commented Apr 23, 2018

As already mentioned in #332 according to https://forum.unified-automation.com/post282.html the DataChangeFilter allows clients to get subscription updates even if the value does not change. I need this kind of functionality because of legacy components, so I can't switch to e.g. Events.

To achieve this I removed the filter for identical values and only avoid calling the callbacks of a value if the timestamps are exactly the same. The actual filtering based on the DataChangeFilter is done similar to the deadband filter. I added a new subscription method which enables clients, tools and tests to subscribe with a DataChangeFilter of StatusValueTimestamp.

Please let me know if you have any doubts.

@oroulet
Copy link
Member

oroulet commented Apr 24, 2018

That one is tricky... Need to think about it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants