TypeError on method call with no inputArguments. Added case to handle this. #964
Conversation
…d case to handle this.
| @@ -128,7 +128,7 @@ def test_subscription_count_list(self): | |||
| val = copy(val) # we do not want to modify object in our db, we need a copy in order to generate event | |||
| val.append(i) | |||
| var.set_value(copy(val)) | |||
| time.sleep(0.2) # let last event arrive | |||
There was a problem hiding this comment.
This was too short and causing the test to occasionally fail. I have increased it to 0.3.
| @@ -463,6 +463,8 @@ def _call(self, method): | |||
| res.StatusCode = ua.StatusCode(ua.StatusCodes.BadNothingToDo) | |||
| else: | |||
| try: | |||
| if method.InputArguments is None: | |||
| method.InputArguments = [] | |||
There was a problem hiding this comment.
these lines will never fail. No need to have them under try/except
There was a problem hiding this comment.
These lines will never fail, but the actual method call could. I have put this check in the same scope as the method call for readability. Would you prefer it outside of the try statement?
There was a problem hiding this comment.
OK I just looked at that code. In fact we should only have try/except around the node.call line. Can you move everything else out?
|
Probably fine, but canyou add a test for that new behaviour? I am curious to know when it happend. I thought this was well supported |
|
@craigh92 any news? |
Closes Issue 963