Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add environment variable attribute Framed-IPv6-Prefix when present #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add environment variable attribute Framed-IPv6-Prefix when present #87

wants to merge 3 commits into from

Commits on Apr 6, 2024

  1. add environment variable attribute Framed-IPv6-Prefix when present

    @DimitriPapadopoulos
    DimitriPapadopoulos committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    23aa2fe View commit details
    Browse the repository at this point in the history

  2. consistency between IPv4 and IPv6

    @DimitriPapadopoulos
    DimitriPapadopoulos committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    e46db2e View commit details
    Browse the repository at this point in the history

  3. do not consider opaque type of s_addr as int 

    The current code implies `int` is 4 bytes - which it is on current Linux
platforms - and that `attr_fip->data` is aligned - which I presume it is.

Neverthless, it might be clearer to use memcpy() here.

From the  Linux header <linux/in.h> :
	/* Internet address. */
	struct in_addr {
		__be32	s_addr;
	};
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    e093685 View commit details
    Browse the repository at this point in the history