-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SEC_STAT.IRM bit handling in ARC SEM interrupt entry/exit #1182
Conversation
Related to FreeRTOS#331 Fix the Memory Read Protection Violation from Secure MPU exception on exit from interrupt. * Add `lr r3, [0x09] /* store SEC_STAT.IRM */` and `and r3, r3, 0x8` before `PUSH r3` in `EXCEPTION_PROLOGUE` and `INTERRUPT_PROLOGUE`. * Add `POP r3 /* restore SEC_STAT.IRM */` and `sflag r3` before `POP r30` in `EXCEPTION_EPILOGUE` and `INTERRUPT_EPILOGUE`.
Quality Gate passedIssues Measures |
Hi @vishwamartur, |
@vishwamartur Would you please share how you tested these changes? |
Sorry, I haven't tested these changes yet as I don't currently have access to a compatible board for this setup. If you have any recommendations for an alternative testing approach or an emulator that supports this configuration, please let me know, and I'll be happy to proceed accordingly. Thank you! |
This is a 3P port and I do not have the hardware to test the changes. I do not think we can merge untested changes. Do you plan to test these changes? Also, how did you decide what changes are needed - this information may help us in reviewing? |
Hi, I just wanted to warn that the author of this PR has spammed many repositories with AI-generated nonsense. If you consider this PR to be nonsensical too, please consider reporting them as spam. Just for reference: |
@jeanthom Thank you for informing us. @vishwamartur Would you please share if you plan to test these changes. I am also interested in learning how did you decide which changes are needed. |
I am closing this PR. Please open a new one when you have tested the changes. |
Related to #331
Fix the Memory Read Protection Violation from Secure MPU exception on exit from interrupt.
lr r3, [0x09] /* store SEC_STAT.IRM */
andand r3, r3, 0x8
beforePUSH r3
inEXCEPTION_PROLOGUE
andINTERRUPT_PROLOGUE
.POP r3 /* restore SEC_STAT.IRM */
andsflag r3
beforePOP r30
inEXCEPTION_EPILOGUE
andINTERRUPT_EPILOGUE
.