-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ARM_CA53_64_BIT/_SRE to Arm_AARCH64/_SRE #822
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 6 6
Lines 2549 2549
Branches 608 608
=======================================
Hits 2387 2387
Misses 107 107
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
portable/GCC/README.md
Outdated
the T32 and A32 instruction sets. Follow the [link](https://developer.arm.com/Architectures/A-Profile%20Architecture) | ||
for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the T32 and A32 instruction sets. Follow the [link](https://developer.arm.com/Architectures/A-Profile%20Architecture) | |
for more information. | |
the T32 and A32 instruction sets. Follow the | |
[link](https://developer.arm.com/Architectures/A-Profile%20Architecture) | |
for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
The Cortex-A53 ports are generic and can be used as a starting point for other Armv8-A application processors. Therefore, rename `ARM_CA53_64_BIT` to `Arm_AARCH64` and `ARM_CA53_64_BIT_SRE` to `Arm_AARCH64_SRE`. With this renaming, existing projects that use old port, should migrate to renamed port as follows: * `ARM_CA53_64_BIT` -> `Arm_AARCH64` * `ARM_CA53_64_BIT_SRE` -> `Arm_AARCH64_SRE` Signed-off-by: Devaraj Ranganna <[email protected]>
c8be7db
to
54b3b75
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The Cortex-A53 ports are generic and can be used as a starting point for other Armv8-A application processors. Therefore, rename `ARM_CA53_64_BIT` to `Arm_AARCH64` and `ARM_CA53_64_BIT_SRE` to `Arm_AARCH64_SRE`. With this renaming, existing projects that use old port, should migrate to renamed port as follows: * `ARM_CA53_64_BIT` -> `Arm_AARCH64` * `ARM_CA53_64_BIT_SRE` -> `Arm_AARCH64_SRE` Signed-off-by: Devaraj Ranganna <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Description
The Cortex-A53 ports are generic and can be used as a starting point for other Armv8-A application processors. Therefore, rename
ARM_CA53_64_BIT
toArm_AARCH64
andARM_CA53_64_BIT_SRE
toArm_AARCH64_SRE
.With this renaming, existing projects that use old port, should migrate to renamed port as follows:
ARM_CA53_64_BIT
->Arm_AARCH64
ARM_CA53_64_BIT_SRE
->Arm_AARCH64_SRE
Test Steps
There are no functional changes.
Checklist:
Related Issue
#565
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.