STM32 network interface bug fixes #1253
Open
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2025 14:12
It is not defined anywhere in TCP or FreeRTOS.
* The bug has been fixed in the F7 driver: STMicroelectronics/stm32f7xx-hal-driver@2770385 * After verification the drivers shipped with FreeRTOS-Plus-TCP contain the fix already. * The bug is still present for the F4 drivers. * Updated the warning accordingly. * Enforced assert only when compiling for STM32F4.
|
|
||
| void ETH_IRQHandler( void ) | ||
| { | ||
| traceISR_ENTER(); |
There was a problem hiding this comment.
traceISR_ENTER is part of the trace macros that got added to FreeRTOS kernel with FreeRTOS/FreeRTOS-Kernel#659
The change is part of the Kernel V11.0.0 and above.
I would suggest keeping it.
There was a problem hiding this comment.
Yes I see
#ifndef traceISR_ENTER
#define traceISR_ENTER()
#endif
What if I upgrade my +TCP and keep on using an older kernel?
void ETH_IRQHandler( void )
{
+
+ #if defined( traceISR_ENTER )
+ /* The following macro is defined in FreeRTOS.h
+ * in kernels "V11.2.0" or higher. */
+ traceISR_ENTER();
+ #endif
ETH_HandleTypeDef * pxEthHandle = &xEthHandle;Hi @ldehenni, thanks for you PR.
What about the above code?
There was a problem hiding this comment.
@HTRamsey , are you OK with this PR?
@tony-josi-aws , shall we add a default declaration like:
+ #if defined( traceISR_ENTER )
+ /* The following macro is defined in FreeRTOS.h
+ * in kernels "V11.2.0" or higher. */
+ traceISR_ENTER();
+ #endifThanks
|
Thanks for taking time to contribute to FreeRTOS+TCP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STM32 network interface bug fixes
Description
All modifications are isolated to the STM32 networkinterface.c file.
A documented bug in the STM32 HAL drivers has since been fixed for the F7 port (STMicroelectronics/stm32f7xx-hal-driver@2770385).
I removed warnings and asserts related to said target (F7), but kept enforcing them for F4.
In the network driver traceISR_ENTER() is called but isn't defined anywhere, not in TCP or in FreeRTOS.
I have removed it, but defining an empty macro in the appropriate file would also work.
As it wasn't respecting the
iptraceXXXI sepcifically didn't add it to the ip default macros.Test Steps
Compiling for STM32F7
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.