Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MQTT v5.x #312

Closed
wants to merge 1 commit into from

Conversation

vishwamartur
Copy link

Related to #267

Add support for MQTT v5.x to the coreMQTT library.

  • manifest.yml

    • Update version to "v5.0.0+".
    • Update description to include MQTT v5.0 support.
  • source/core_mqtt_serializer.c

    • Add definition for MQTT protocol version 5.0.
    • Implement serialization and deserialization for MQTT v5.x packets.
    • Add handling for MQTT v5.x properties in serializeConnectPacket.
  • source/include/core_mqtt_config_defaults.h

    • Add configuration option for enabling MQTT v5.x support.
    • Define MQTT_VERSION_5_ENABLED macro.
  • source/include/transport_interface.h

    • Add support for MQTT v5.x in transport interface.
    • Update TransportInterface_t to handle MQTT v5.x packets.

Related to FreeRTOS#267

Add support for MQTT v5.x to the coreMQTT library.

* **manifest.yml**
  - Update `version` to "v5.0.0+".
  - Update `description` to include MQTT v5.0 support.

* **source/core_mqtt_serializer.c**
  - Add definition for MQTT protocol version 5.0.
  - Implement serialization and deserialization for MQTT v5.x packets.
  - Add handling for MQTT v5.x properties in `serializeConnectPacket`.

* **source/include/core_mqtt_config_defaults.h**
  - Add configuration option for enabling MQTT v5.x support.
  - Define `MQTT_VERSION_5_ENABLED` macro.

* **source/include/transport_interface.h**
  - Add support for MQTT v5.x in transport interface.
  - Update `TransportInterface_t` to handle MQTT v5.x packets.
@ActoryOu
Copy link
Member

ActoryOu commented Nov 1, 2024

Hi @vishwamartur,
Thanks for your contribution! But I don't see any implementation for MQTT 5.0. Could you help check if all changes on your side are pushed to the PR?

Thank you.

@amazonKamath
Copy link
Member

@vishwamartur we are working on MQTTv5 and here is a in progress draft PR: #301 . This PR contains most of the MQTTv5 features barring subscribe and incoming publish handling. We intend to restart work on this PR to implement the remaining feature in the next few weeks, and would appreciate contributions to that PR, rather than duplicate efforts. Let us know if you would want to work on the PR I shared. Thanks.

@vishwamartur
Copy link
Author

Hi @ActoryOu and @amazonKamath ,

Thank you for the feedback! I've reviewed draft PR #301 and see the progress on MQTTv5. I'll align my contributions with the existing work to avoid duplication and help streamline the process.

If there are specific tasks or areas where you'd like me to focus, please let me know—I’ll be glad to assist in any way needed.

Thanks again!

@amazonKamath
Copy link
Member

@vishwamartur Thanks. The PR#301 doesn't yet support incoming publish packets and subscribe features for v5. Any efforts in that area is welcome. Please create any PR on top of PR#301 if you wish to contribute for MQTTv5. Thanks.

@amazonKamath
Copy link
Member

I am closing this PR, since we prefer to take our existing MQTTv5 implementation in PR#301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants